tests: replace ok(ret == KNOT_E???) with is_int(KNOT_E???, ret) to ease debugging (!659) · Merge requests · Knot projects / Knot DNS · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Petr Špaček requested to merge tap_ok_to_isinst into master Jan 27, 2017

Throwing away unexpected retun codes makes debugging harder. TAP function is_int can nicely log mismatches which makes debugging easier.

To make our lives easier I replaced all ok(ret == KNOT_E???) checks with is_int() calls. It was done using following command

manual review and reverts in libknot/test_control.c.

$ find -name '*.c' | xargs sed -i 's#ok(ret == (KNOT_E[0-9A-Z_]+),#is_int(\1, ret,#'