Skip to content
Snippets Groups Projects

Fixed wrong dname comparison #240

Merged Fixed wrong dname comparison #240
dname-fix into master
Merged Ghost User requested to merge dname-fix into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
    Ghost User @ghost ·
    Author Contributor

    Fixes the issue from what I've tested. Reason - direct pointer comparison instead of calling knot_dname_cmp, this error is not applicable to previous versions, because of DNAME duplication, which is only present in v1.4. Nevertheless, the code should be checked for similar problems.

  • Ondřej Surý
    Ondřej Surý @ondrej ·
    Contributor

    lgtm, but I concur that it needs to be checked in the whole source tree.

Please register or sign in to reply