Skip to content
Snippets Groups Projects

fix leak on error in zone loading

Merged fix leak on error in zone loading
zone-loading-leak-on-error into master
Merged Jan Včelák requested to merge zone-loading-leak-on-error into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jan Včelák
    Jan Včelák @jvcelak ·
    Author Contributor

    Added one more commit.

  • Ghost User
    Ghost User @ghost started a thread on the diff
    • src/knot/server/zone-load.c
    185 185 * \retval KNOT_EINVAL on invalid parameters.
    186 186 * \retval KNOT_ENOMEM on failed memory allocation.
    187 187 */
    188 static int zones_set_acl(acl_t **acl, list_t* acl_list)
    188 static int set_acl(acl_t **acl, list_t* acl_list)
  • Ghost User
    Ghost User @ghost started a thread on the diff
    • src/knot/server/zone-load.c
    504 484 {
    505 485 const char *action = NULL;
    506 486
    507 if (status == ZONE_STATUS_NOT_FOUND) {
    508 action = "bootstrapped";
    509 } else if (status == ZONE_STATUS_FOUND_NEW) {
    510 action = "loaded";
    511 } else if (status == ZONE_STATUS_FOUND_CURRENT) {
    512 action = "is up-to-date";
    513 } else if (status == ZONE_STATUS_FOUND_UPDATED) {
    514 action = "reloaded";
    487 switch (status) {
    488 case ZONE_STATUS_NOT_FOUND: action = "bootstrapped"; break;
    489 case ZONE_STATUS_FOUND_NEW: action = "loaded"; break;
    490 case ZONE_STATUS_FOUND_CURRENT: action = "is up-to-date"; break;
    491 case ZONE_STATUS_FOUND_UPDATED: action = "reloaded"; break;
  • Ghost User
  • Ghost User
  • Ghost User
    Ghost User @ghost ·
    Contributor

    else lgtm

  • Jan Včelák
    Jan Včelák @jvcelak ·
    Author Contributor

    fixed

    • Please register or sign in to reply