Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Knot DNS
Knot DNS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 22
    • Issues 22
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 17
    • Merge Requests 17
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Knot projects
  • Knot DNSKnot DNS
  • Merge Requests
  • !987

Merged
Opened Mar 04, 2019 by Daniel Kahn Gillmor@dkgContributor

Avoid recording -fdebug-prefix-map= from CFLAGS and CPPFLAGS

  • Overview 1
  • Commits 1
  • Changes 1

It's not particularly useful to record -fdebug-prefix-map= and friends in the list of used CFLAGS arguments. Additionally, since these compiler arguments are typically used to make reproducible binary artifacts by stripping out information about the ephemeral build path used, embedding them in the resulting binary actually re-introduces the reproducibility problem.

Note that gcc itself omits these values from the DWARF information that it generates:

https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/dwarf2out.c;h=1b17f2bc1d5eef3d3ef70abf92a4d09da285d2b8;hb=HEAD#l24396

You can see the reproducibility issue here:

https://tests.reproducible-builds.org/debian/dbd/unstable/amd64/knot_2.7.6-2.diffoscope.html

Edited Mar 04, 2019 by Daniel Kahn Gillmor
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: knot/knot-dns!987
Source branch: clean-cached-cflags

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.