modules/policy: add 'domain' filter for equality matching (!1228) · Merge requests · Knot projects / Knot Resolver · GitLab

Snippets Groups Projects

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged modules/policy: add 'domain' filter for equality matching

policy-domain into master

All threads resolved!

Merged Oto Šťáva requested to merge policy-domain into master 3 years ago

All threads resolved!

Activity

Tomas Krizek @tkrizek started a thread on an old version of the diff 3 years ago

Resolved 3 years ago by Vladimír Čunát
Vladimír Čunát @vcunat started a thread on an old version of the diff 3 years ago

Resolved 3 years ago by Tomas Krizek
Tomas Krizek @tkrizek · 3 years ago

Owner

Resolved 3 years ago by Vladimír Čunát

I think the new func should also have some test coverage. A relatively quick test without many modifications could be:

use policy.add(policy.domains(policy.DENY, {todname('example.com.')})) before line 3 in https://gitlab.nic.cz/knot/knot-resolver/-/blob/master/modules/policy/test.integr/kresd_config.j2

query example.com in https://gitlab.nic.cz/knot/knot-resolver/-/blob/master/modules/policy/test.integr/refuse.rpl and check it returns an NXDOMAIN answer.

Last reply by Oto Šťáva 3 years ago
Vladimír Čunát @vcunat started a thread on an old version of the diff 3 years ago

Resolved 3 years ago by Oto Šťáva
Oto Šťáva added 1 commit 3 years ago
added 1 commit

b62eeb67 - modules/policy: use a list of domains, instead of a single domain

Compare with previous version
Oto Šťáva added 1 commit 3 years ago
added 1 commit

788fe931 - modules/policy: add integration test for 'domains' function

Compare with previous version
Oto Šťáva added 1 commit 3 years ago
added 1 commit

035012aa - modules/policy: fix unused variable (luacheck)

Compare with previous version
Vladimír Čunát @vcunat started a thread on an old version of the diff 3 years ago

Resolved 3 years ago by Oto Šťáva
Oto Šťáva added 1 commit 3 years ago
added 1 commit

c48506c0 - modules/policy: fix doc

Compare with previous version
Vladimír Čunát added 1 commit 3 years ago
added 1 commit

112650c6 - modules/policy docs: tweak an example

Compare with previous version
Oto Šťáva added 1 commit 3 years ago
added 1 commit

c1a7208b - modules/policy: deduplicate doc

Compare with previous version
Oto Šťáva added 11 commits 3 years ago
added 11 commits

c1a7208b...e81d0e3c - 4 commits from branch master

dde426bf - modules/policy: add 'domain' filter for equality matching

8e60fd10 - modules/policy: use a list of domains, instead of a single domain

c24cab71 - modules/policy: add integration test for 'domains' function

c3e378ac - modules/policy: fix unused variable (luacheck)

1f7223f8 - modules/policy: fix doc

ee8993bd - modules/policy docs: tweak an example

57d61757 - modules/policy: deduplicate doc

Compare with previous version
Toggle commit list
Tomas Krizek resolved all threads 3 years ago

resolved all threads
Tomas Krizek approved this merge request 3 years ago

approved this merge request
Tomas Krizek merged 3 years ago

merged
Tomas Krizek mentioned in commit 8500ee2f 3 years ago

mentioned in commit 8500ee2f

Please register or sign in to reply