manager: datamodel: missing configuration

• PROXYv2

  network:
    proxy-v2:
      allow: ["172.22.0.1", "172.18.1.0/24"]
    # by default it is turned off; 'net.proxy_allowed({})' is used in Lua configuration
    proxy-v2: false

• debugging options were added some time ago.

Are there any other changes that I missed? Feel free to suggest any changes in configuration schema. @ostava @vcunat

related to #715 (closed)

added manager label

approved this merge request

Are there any other changes that I missed?

I think it's best to read the NEWS file, as configuration changes should surely be noted in there. I don't know which kresd version you used as a base.

unapproved this merge request

Nit: I deliberately omitted the v2 from the net.proxy_allowed function name to future-proof it in case (albeit unlikely) we decide to implement PROXYv1 and/or a new version of the PROXY protocol comes around in the future. I would expect we would just want to enable all of the protocol versions at once at such a point.

I would personally omit the v2 in the YAML config as well for the same reason. Maybe name it proxy-protocol for it to be clearer?

added 1 commit

• 0eb06177 - manager: datamodel: PROXYv2 option renamed

Compare with previous version

marked this merge request as ready

mentioned in issue #715 (closed)

approved this merge request

resolved all threads

mentioned in commit 924c1d79

merged

I like how simple this addition is. The jinja-lua stuff is a little hard to read, but overall it's still very simple.

There is still room for improvement in the jinja2 configuration template. jinja-lua especially without syntax highlighting is pain.