lib/rules: fix a bug in subnet computations (!1562) · Merge requests · Knot projects / Knot Resolver · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Vladimír Čunát requested to merge views-subnets into master Jun 26, 2024

The problem mainly affected subnets not aligned on whole bytes, but maybe also others. Reported: https://lists.nic.cz/hyperkitty/list/knot-resolver-users@lists.nic.cz/message/6P2JPK72WMVLP45TDV42DTACEA2N5NW2/

I'm really sorry about this; no idea why I thought that the simple multiplication would suffice.

FIXME: more review and testing, ~~and perhaps also the comments~~.

Edited Jul 16, 2024 by Vladimír Čunát