Skip to content
Snippets Groups Projects

iterator: answer unimplemented opcodes with NOTIMP.

Open menakite requested to merge menakite/knot-resolver:unimp-opcodes-notimp into master

Before:

$ dig +nocmd +nostats +opcode=4 soa cz 
;; Got answer:
;; ->>HEADER<<- opcode: NOTIFY, status: NOERROR, id: 24158
;; flags: qr rd ra ad; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
;; QUESTION SECTION:
;cz.				IN	SOA

;; ANSWER SECTION:
cz.			3408	IN	SOA	a.ns.nic.cz. hostmaster.nic.cz. 1724901520 900 300 604800 900

After:

$ dig +nocmd +nostats +opcode=4 soa cz @::1 # this dig doesn't support EDEs
;; Got answer:
;; ->>HEADER<<- opcode: NOTIFY, status: NOTIMP, id: 20907
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
; OPT=15: 00 15 35 37 43 4b ("..57CK")
;; QUESTION SECTION:
;cz.				IN	SOA

Merge request reports

Members who can merge are allowed to add commits.
Checking approval status
Ready to merge by members who can write to the target branch.

Merge details

  • The source branch is 340 commits behind the target branch.
  • 0 commits and 1 merge commit will be added to .
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply