view: change to a more natural semantics (!678) · Merge requests · Knot projects / Knot Resolver · GitLab

Snippets Groups Projects

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged view: change to a more natural semantics

view into master

Merged Vladimír Čunát requested to merge view into master 6 years ago

I think it makes more sense. Real-life example: https://lists.nic.cz/pipermail/knot-resolver-users/2018/000081.html

I tested the change briefly on that example (in addition to the deckard test we had).

Edited 6 years ago by Petr Špaček

Activity

Vladimír Čunát @vcunat · 6 years ago

Author Owner

The semantics before this MR doesn't seem to allow the linked use case in any reasonable way.
Petr Špaček assigned to @pspacek 6 years ago

assigned to @pspacek
Petr Špaček added 260 commits 6 years ago
added 260 commits

392ffb9b...140b2ec1 - 256 commits from branch master

037fa290 - view doc: warn against split-horizon DNS

a83abf29 - view: change to a more natural semantics

cac28031 - tests: move view tests from Deckard repo to kresd repo

f990d62f - WIP: an attempt to test new semantics

Compare with previous version
Toggle commit list
Petr Špaček marked as a Work In Progress from f990d62f 6 years ago

marked as a Work In Progress from f990d62f
Vladimír Čunát added 16 commits 6 years ago
added 16 commits

f990d62f...8b8da77e - 11 commits from branch master

aaba838f - view doc: warn against split-horizon DNS

996db693 - view: change :addr to a more natural semantics

6c0313b3 - view: allow multiple :tsig rules with the same key

02ce9925 - tests: move view tests from Deckard repo to kresd repo

01234c67 - WIP: an attempt to test new semantics

Compare with previous version
Toggle commit list
Vladimír Čunát added 1 commit 6 years ago
added 1 commit

3d9d47f3 - view doc: better explain rule order

Compare with previous version
Vladimír Čunát added 1 commit 6 years ago
added 1 commit

d2c9b6d8 - view doc: better explain rule order

Compare with previous version
Vladimír Čunát added 1 commit 6 years ago
added 1 commit

7e071824 - modules/{policy,view}: do not act if FAIL or DONE

Compare with previous version
Petr Špaček added 3 commits 6 years ago
added 3 commits

8abf7ce9 - fixup! WIP: an attempt to test new semantics

1a7d1cdd - WIP: test

1dcb2ab2 - WIP: tests failing for two view:addr() rules

Compare with previous version
Petr Špaček added 34 commits 6 years ago
added 34 commits

1dcb2ab2...80503635 - 27 commits from branch master

c5f04144 - view doc: warn against split-horizon DNS

732a6616 - view: change :addr to a more natural semantics

1f2986db - view: allow multiple :tsig rules with the same key

c16728f5 - modules/{policy,view}: do not act if FAIL or DONE

0ba59805 - tests: move view tests from Deckard repo to kresd repo

16611984 - view: test new semantics

8ce76d00 - view doc: better explain rule order

Compare with previous version
Toggle commit list
Petr Špaček unmarked as a Work In Progress 6 years ago

unmarked as a Work In Progress
Petr Špaček changed the description 6 years ago

changed the description
Petr Špaček removed assignee 6 years ago

removed assignee
Vladimír Čunát merged 6 years ago

merged
Vladimír Čunát mentioned in commit 7db1882e 6 years ago

mentioned in commit 7db1882e
Vladimír Čunát mentioned in commit a901d146 5 years ago

mentioned in commit a901d146
Vladimír Čunát mentioned in commit 0a57436b 5 years ago

mentioned in commit 0a57436b

Please register or sign in to reply