daemon TCP to upstream: don't send wrong message length (!816) · Merge requests · Knot projects / Knot Resolver · GitLab

Snippets Groups Projects

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged daemon TCP to upstream: don't send wrong message length

p/uv_write-lifetime into master

All threads resolved!

Merged Vladimír Čunát requested to merge p/uv_write-lifetime into master 5 years ago

All threads resolved!

See the added comments. Such bugs are tricky, because the old code would typically work just fine, only if libuv/OS decided to postpone copying the data (perhaps large load), we would send two bytes from this address on C stack - their later value (hard to predict what).

Security risks: the two bytes might theoretically contain information that was more or less private and we just send it to some DNS server (possibly over unencrypted TCP), but ATM I find it very unlikely that this bug could be practically exploited.

Activity

Petr Špaček @pspacek started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Vladimír Čunát
Vladimír Čunát added 9 commits 5 years ago
added 9 commits

53563b94...a4a29c67 - 8 commits from branch master

05b70100 - daemon TCP to upstream: don't send wrong message length

Compare with previous version
Vladimír Čunát added 1 commit 5 years ago
added 1 commit

10a113d7 - daemon TCP to upstream: don't send wrong message length

Compare with previous version
Vladimír Čunát resolved all discussions 5 years ago

resolved all discussions
Tomas Krizek merged 5 years ago

merged
Tomas Krizek mentioned in commit fd15bc6c 5 years ago

mentioned in commit fd15bc6c
Petr Špaček @pspacek · 5 years ago

Contributor

Thanks, this seems to be much cleaner to me.

Please register or sign in to reply