iterate: fix limit on CNAME chain length (!899) · Merge requests · Knot projects / Knot Resolver · GitLab

Snippets Groups Projects

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.

Merged iterate: fix limit on CNAME chain length

knot/security/knot-resolver:cname-limit into master

Merged Vladimír Čunát requested to merge knot/security/knot-resolver:cname-limit into master 5 years ago

The accounting was just broken and overly messy anyway.

TODO:

NEWS for both changes
perhaps some tests

Edited 5 years ago by Tomas Krizek

Activity

Vladimír Čunát changed milestone to %4.3.0 5 years ago

changed milestone to %4.3.0
Petr Špaček @pspacek · 5 years ago

Contributor
We really need a test for this.

14 CNAMEs should fit in default 4 kB buffer in Deckard.

Please add kresd-specific test, preferably one with chain length on allowed limit and another one with chain of "allowed length + 1". Thanks.
Vladimír Čunát assigned to @vcunat 5 years ago

assigned to @vcunat
Petr Špaček added bug label 5 years ago

added bug label
Petr Špaček marked the checklist item perhaps some tests as completed 5 years ago

marked the checklist item perhaps some tests as completed
Petr Špaček unmarked as a Work In Progress 5 years ago

unmarked as a Work In Progress
Petr Špaček changed the description 5 years ago

changed the description
Petr Špaček added 11 commits 5 years ago
added 11 commits

88f1e13e...9a0835d1 - 6 commits from branch knot:master

7684f855 - iterate: fix limit on CNAME chain length

c8db8dcb - iterate: reduce CNAME length limit: 40 -> 13

90a6439f - iterate: tests for CNAME chain restrictions

777c652b - iterate: clarify error messages about CNAME chains

db1cb7ea - ci: skip Travis build for security repo

Compare with previous version
Toggle commit list
Vladimír Čunát added 10 commits 5 years ago
added 10 commits

db1cb7ea...a39c478e - 5 commits from branch knot:master

20496036 - iterate: fix limit on CNAME chain length

4fbd5baf - iterate: reduce CNAME length limit: 40 -> 13

b2b8cb0a - iterate: tests for CNAME chain restrictions

c0fcb467 - iterate: clarify error messages about CNAME chains

50aa520e - ci: skip Travis build for security repo

Compare with previous version
Toggle commit list
Tomas Krizek marked the checklist item NEWS for both changes as completed 5 years ago

marked the checklist item NEWS for both changes as completed
Tomas Krizek merged 5 years ago

merged
Tomas Krizek mentioned in commit b6baac2b 5 years ago

mentioned in commit b6baac2b

Please register or sign in to reply