module API+ABI: remove one level of indirection
... for layers and props. This breaks C module API+ABI. It seemed weird to repeatedly call a function that returns a pointer to a structure in which we find the function we want to actually call. We've never used changing these functions AFAIK, and the target functions could easily be written to change their behavior instead (i.e. move the indirection *inside* the function). When breaking this, I also removed these two (_layers and _props) from the dynamic symbols (to be) exported from the C modules. They always pointed to memory belonging inside the module, and they seem quite sensible to be set up by the _init symbol instead.
Showing
- daemon/engine.c 3 additions, 4 deletionsdaemon/engine.c
- daemon/ffimodule.c 3 additions, 10 deletionsdaemon/ffimodule.c
- lib/layer/cache.c 6 additions, 5 deletionslib/layer/cache.c
- lib/layer/iterate.c 5 additions, 4 deletionslib/layer/iterate.c
- lib/layer/validate.c 5 additions, 9 deletionslib/layer/validate.c
- lib/module.c 25 additions, 29 deletionslib/module.c
- lib/module.h 8 additions, 7 deletionslib/module.h
- lib/resolve.c 2 additions, 3 deletionslib/resolve.c
- lib/utils.c 1 addition, 1 deletionlib/utils.c
- modules/README.rst 2 additions, 0 deletionsmodules/README.rst
- modules/bogus_log/bogus_log.c 12 additions, 21 deletionsmodules/bogus_log/bogus_log.c
- modules/cookies/cookies.c 16 additions, 25 deletionsmodules/cookies/cookies.c
- modules/dnstap/dnstap.c 7 additions, 10 deletionsmodules/dnstap/dnstap.c
- modules/edns_keepalive/edns_keepalive.c 4 additions, 6 deletionsmodules/edns_keepalive/edns_keepalive.c
- modules/hints/hints.c 17 additions, 30 deletionsmodules/hints/hints.c
- modules/nsid/nsid.c 16 additions, 24 deletionsmodules/nsid/nsid.c
- modules/stats/stats.c 15 additions, 27 deletionsmodules/stats/stats.c
Please register or sign in to comment