ready for big refactoring?
@ostava Hi! I'm thinking that this repo is in need of big refactoring, so I would like to consult with you.
First, are there pieces you really like/want to keep?
I can see following problems which I would like to work on:
- Parametrization is total mess. Variable names are well hidden, no checks are performed before role is executed etc. This makes it nightmare to use from anything except one frozen environment. Something like https://docs.ansible.com/ansible/latest/collections/ansible/builtin/validate_argument_spec_module.html should help
- The same toolchain can be used with auths, but it requires some more parametrization - like integrating dnsperf in some way. That leads to more generic names like "target" instead of "resolver", renaming references to "shotgun" etc.
- ansible-lint almost explodes when I execute it - so a big cleanup is in order
- dnsperf role does not really work as it depends on Dockerfile which is broken (in respdiff repo) and I'm sure I will find more once I start poking into it.
Do you have some preferences for this repo?
Thank you for your time!