Move linestyle and marker customization to MPL style

Also change the default to improve readability.

tools/mplhlpr/shotgun.mplstyle

@@ -9,5 +9,8 @@ figure.constrained_layout.use: True
 # autolayout is not compatible with constrained_layout
 figure.autolayout: False
 
+lines.linestyle: "dotted"
+lines.marker: "x"
+
 # deterministic SVG output for easier diff-ing
 svg.hashsalt: 0      # If not None, use this string as hash salt instead of uuid4

tools/plot-connections.py

@@ -75,7 +75,7 @@ def plot(ax, data, label, eval_func, min_timespan=0, color=None):
         xvalues.append(time)
         yvalues.append(eval_func(stats))
 
-    ax.plot(xvalues, yvalues, label=label, marker="o", linestyle="--", color=color)
+    ax.plot(xvalues, yvalues, label=label, color=color)
 
 
 def main():

tools/plot-latency.py

@@ -305,7 +305,7 @@ def main():
         for name_re, style in args.linestyle.items():
             if name_re.search(name):
                 linestyle = style
-        ax.plot(group_x, group_yavg, lw=2, label=label, linestyle=linestyle)
+        ax.plot(group_x, group_yavg, lw=2, label=label, marker="", linestyle=linestyle)
 
     plt.legend()
     plt.savefig(args.output)

tools/plot-packet-rate.py

@@ -47,7 +47,7 @@ def plot(ax, data, label, since, until, line_props):
         xvalues.append(time_s)
         yvalues.append(rate)
 
-    ax.plot(xvalues, yvalues, label=label, linestyle="", **line_props)
+    ax.plot(xvalues, yvalues, label=label, **line_props)
     ax.set_xlim(xmin=since)
     if not math.isfinite(until):
         until = xvalues[-1]

tools/plot-response-rate.py

@@ -145,8 +145,8 @@ def plot_response_rate(
     eval_func=None,
     min_timespan=0,
     min_rate=0,
-    marker="o",
-    linestyle="--",
+    marker=None,
+    linestyle=None,
     color=None,
 ):
     stats_periodic = data["stats_periodic"]
@@ -341,7 +341,6 @@ def process_file(json_path, json_color, args, ax):
                 min_timespan=min_timespan,
                 min_rate=args.ignore_rcodes_rate_pct,
                 marker=f"${symbol}$",
-                linestyle="dotted",
                 color=cur_rcode_colors[rcode],
             )
 
@@ -360,7 +359,6 @@ def process_file(json_path, json_color, args, ax):
             eval_func=eval_func,
             min_timespan=min_timespan,
             marker="$\\sum$",
-            linestyle="dotted",
             color=json_color,
         )