Skip to content
  • Maria Matejka's avatar
    973aa37e
    Fix memory pre-allocation · 973aa37e
    Maria Matejka authored
    When BIRD has no free memory mapped, it allocates several pages in
    advance just to be sure that there is some memory available if needed.
    This hysteresis tactics works quite well to reduce memory ping-ping with
    kernel.
    
    Yet it had a subtle bug: this pre-allocation didn't take a memory
    coldlist into account, therefore requesting new pages from kernel even
    in cases when there were other pages available. This led to slow memory
    bloating.
    
    To demonstrate this behavior fast enough to be seen well, you may:
      * temporarily set the values in sysdep/unix/alloc.c as follows to
        exacerbate the issue:
          #define KEEP_PAGES_MAIN_MAX    4096
          #define KEEP_PAGES_MAIN_MIN    1000
          #define CLEANUP_PAGES_BULK     4096
      * create a config file with several millions of static routes
      * periodically disable all static protocols and then reload config
      * log memory consumption
    
    This should give you a steady growth rate of about 16kB per cycle. If
    you don't set the values this high, the issue happens much more slowly,
    yet after 14 days of running, you are going to see an OOM kill.
    
    After this fix, pre-allocation uses the memory coldlist to get some hot
    pages and the same test as described here gets you a perfectly stable
    constant memory consumption (after some initial wobbling).
    
    Thanks to NIX-CZ for reporting and helping to investigate this issue.
    Thanks to Santiago for finding the cause in the code.
    973aa37e
    Fix memory pre-allocation
    Maria Matejka authored
    When BIRD has no free memory mapped, it allocates several pages in
    advance just to be sure that there is some memory available if needed.
    This hysteresis tactics works quite well to reduce memory ping-ping with
    kernel.
    
    Yet it had a subtle bug: this pre-allocation didn't take a memory
    coldlist into account, therefore requesting new pages from kernel even
    in cases when there were other pages available. This led to slow memory
    bloating.
    
    To demonstrate this behavior fast enough to be seen well, you may:
      * temporarily set the values in sysdep/unix/alloc.c as follows to
        exacerbate the issue:
          #define KEEP_PAGES_MAIN_MAX    4096
          #define KEEP_PAGES_MAIN_MIN    1000
          #define CLEANUP_PAGES_BULK     4096
      * create a config file with several millions of static routes
      * periodically disable all static protocols and then reload config
      * log memory consumption
    
    This should give you a steady growth rate of about 16kB per cycle. If
    you don't set the values this high, the issue happens much more slowly,
    yet after 14 days of running, you are going to see an OOM kill.
    
    After this fix, pre-allocation uses the memory coldlist to get some hot
    pages and the same test as described here gets you a perfectly stable
    constant memory consumption (after some initial wobbling).
    
    Thanks to NIX-CZ for reporting and helping to investigate this issue.
    Thanks to Santiago for finding the cause in the code.
Loading