Maria Matejka authored 1 year ago and Ondřej Zajíček committed 1 year ago

This is just a preparationary refactoring to allow type-based method
tables.

Maria Matejka authored 1 year ago and Ondřej Zajíček committed 1 year ago

This avoids unnecessary collapsed soft scopes caused by keyword symbol multiallocation.

Maria Matejka authored 2 years ago and Ondřej Zajíček committed 1 year ago

This is a backport cherry-pick of commits
  165156be
  cce974e8

from the v3.0 branch as we need symbol hashes directly inside their
scopes for more general usage than before.

According to RFC 5882, system should not interpret the local or remote
session state transition to AdminDown as failure. We followed that for
the local session state but not for the remote session state (which
just triggered a transition of the local state to Down). The patch
fixes that.

We do not properly generate AdminDown on our side, so the patch is
relevant just for interoperability with other systems.

Thanks to Sunnat Samadov for the bugreport.

Most syntactic constructs in BIRD configuration (e.g. protocol options)
are defined as keywords, which are distinct from symbols (user-defined
names for protocols, variables, ...). That may cause backwards
compatibility issue when a new feature is added, as it may collide with
existing user names.

We can allow keywords to be shadowed by symbols in almost all cases to
avoid this issue.

This replaces the previous mechanism, where shadowable symbols have to be
explictly added to kw_syms.

The previous approach (use VOID constant for variable initialization)
failed due to dynamic type check failure.

Thanks to Alexander Zubkov <green@qrator.net> for the bugreport.

Thanks to Alexander Zubkov for the notice.

Nonterminal bytestring allows to provide expressions to be evaluated in
places where BYTETEXT is used now: passwords, radv custom option.

Based on the patch from Alexander Zubkov <green@qrator.net>, thanks!

Alexander Zubkov authored 1 year ago and Ondřej Zajíček committed 1 year ago

Replace f_eval_int() function with a type-generic variant: cf_eval().
Implement similar fuction: cf_eval_int() via inline call to cf_eval().

Alexander Zubkov authored 1 year ago and Ondřej Zajíček committed 1 year ago

 - Rename BYTESTRING lexem to BYTETEXT, not to collide with 'bytestring' type name
 - Add bytestring type with id T_BYTESTRING (0x2c)
 - Add from_hex() filter function to create bytestring from hex string
 - Add filter test cases for bytestring type

Minor changes by committer.

Based on patch from Alexander Zubkov, thanks!

Despite not having defined 'master interface', VRF interfaces should be
treated as being inside respective VRFs. They behave as a loopback for
respective VRFs. Treating the VRF interface as inside the VRF allows
e.g. OSPF to pick up IP addresses defined on the VRF interface.

For this, we also need to tell apart VRF interfaces and regular interfaces.
Extend Netlink code to parse interface type and mark VRF interfaces with
IF_VRF flag.

Based on the patch from Erin Shepherd, thanks!

Jakub Ružička authored 1 year ago and Ondřej Zajíček committed 1 year ago

It seems all Fedora packages are built from epel7 branch.

Jakub Ružička authored 1 year ago and Ondřej Zajíček committed 1 year ago

The test was written by Maria Matejka, thanks!

Run this using

    apkg test

Jakub Ružička authored 3 years ago and Ondřej Zajíček committed 1 year ago

This will allow compatibility on future apkg config updates.

Jakub Ružička authored 1 year ago and Ondřej Zajíček committed 1 year ago

Mirrors debian patch.

Jakub Ružička authored 2 years ago and Ondřej Zajíček committed 1 year ago

Current is 13, remaining blockers:

- Debian 9 @ 11 (EOL)
- Ubuntu 18.04 @ 12 (EOL 2023-04-02)

Jakub Ružička authored 2 years ago and Ondřej Zajíček committed 1 year ago

Mirrors Debian package change.

RFC 5549 was obsoleted by RFC 8950.

Move all bmp_peer_down() calls to one place and make it synchronous with
BGP session down, ensuring that BMP receives peer_down before route
withdraws from flushing.

Also refactor bmp_peer_down_() message generating code.

Now we use rt_notify() and channels for both feed and notifications,
in both import tables (pre-policy) and regular tables (post-policy).

Remove direct walk in bmp_route_monitor_snapshot().

Remove special rte_announce_in(), so we can use generic rte_announce()
for bot feed and notifications.

 - Manage BMP state through bmp_peer, bmp_stream, bmp_table structures
 - Use channels and rt_notify() hook for route announcements
 - Add support for post-policy monitoring
 - Send End-of-RIB even when there is no routes
 - Remove rte_update_in_notify() hook from import tables
 - Update import tables to support channels
 - Add bmp_hack (no feed / no flush) flag to channels

No need for *_begin(), *_commit(), and *_end() hooks. The hook *_notify()
is sufficient for everything.

The problem was the "/" symbol in the prefix mask that finished the formatting definition prematurely.