omnia-ng-support: Fix Omnia NG LED brightness control

CrumblyLiquidrequested to merge
CrumblyLiquid/packages:omnia-ng-led-fix into master

This MR does three things:

  • Switches the LED trigger from default-on to none
  • Properly restores triggers after setting brightness from 0 to 255
  • Fixes couple typos in the minirainbow.sh script

LED Triggers

When we set the trigger to default-on the kernel will set the brightness to 100% (see ledtrig-default-on.c). And when setting the brightness to 0 the kernel will clear the trigger ([none] means there's no trigger assigned) (see led-class.c).

So if we set brightness to 0 the kernel clears the trigger that was there previously. Then we set the trigger to default-on which will set the LED to maximum brightness which is very annoying (especially at night).

Changing the trigger to none (so not using any trigger) will allow us to set the brightness to whatever we want including turning it off entirely without the kernel getting in our way. We also have to make sure to restore the proper triggers after we loop back around from 0 to 255 brightness (this is only really relevant if TRIGGERS=yes).

Typos

I'm pretty sure that using set_brightness which sets brightness too all of the LEDs is useless and setting brightness for the POWER_LED specifically is better but maybe I'm missing something.

Edited by CrumblyLiquid

Merge request reports