resolver-conf: fix resolver config for mvebu
1 unresolved thread
1 unresolved thread
+ 2
− 2
@@ -42,7 +42,7 @@ endef
@@ -56,7 +56,7 @@ endif
Self sign-up has been disabled due to increased spam activity. If you want to get access, please send an email to a project owner (preferred) or at gitlab(at)nic(dot)cz. We apologize for the inconvenience.
Fixes turris/turris-os-packages#580
Looking at this, shouldn't logic be modified here? Shouldn't we have default config for unbound and kresd and detect if kresd is available and if not use unbound one?
Sure thing. I thought there is
knot-resolver
package available for Turris 1.x, but it seems not. Can you check it, now? I changed it as you suggested. I compiled it for Turris Omnia and Turris 1.x. Verified contents of package. It is how it should be.I was not able to use
ifeq ($(CONFIG_PACKAGE_knot-resolver),y)
, because knot-resolver is not marked as critical package (=Y
)You can probably do:
This rather checks if
CONFIG_PACKAGE_knot-resolver
is not set to empty orn
value. Other option would be to useifeq
andfilter
function to filtery
andn
. Your's choice.I was thinking to filter
y
andn
, but it seemed to me like complicated, but your approach seems good in the end. I will change it. Thanks.Tested for both routers. Unset Knot and set Knot and changes were done correctly.