sentinel.sh dependency

Main issue is in nikola crontab. sentinel.sh is sourced there and allowed_to_run called. Yet, config_load and other OpenWrt functions is missing as functions.sh is never sourced.

This proposed fix seems to me a straightforward solution, as you source what's needed to run the functions provided. Maybe there are some consequences I missed, so please double check this.

changed milestone to %Turris OS 5.1

Also, sentinel.sh, sentinel-functions.sh, etc.. are interpreted via POSIX /bin/sh, yet we use source. I know it works with OpenWrt busybox, but it's not so clean solution.

Anyway, we should unify source or . usage. Some scripts use the former, some the later.

changed the description

changed target branch from master to develop

It looks like you have this based on other merge request. MR request was also pointed to master but looks like it is based on develop (so I changed target). Please include change you are describing in MR message.

assigned to @vmyslivec and unassigned @kkoci

added 1 commit

• 4d8c5624 - sentinel-proxy: Fix dependency on functions

Compare with previous version

added 4 commits

• bedacddb - fixup! sentinel-proxy: Fix dependency on functions
• a09d9c86 - sentinel-proxy: Add an info header to the script
• 7024c1fb - sentinel-firewall: Source OpenWrt functions only if needed
• 3f872ac1 - sentinel-firewall: Add an info header to the script

Compare with previous version

marked as a Work In Progress from bedacddb

added 2 commits

• bcc126c9 - sentinel-firewall: Source OpenWrt functions only if needed
• 7db50d40 - sentinel-firewall: Add an info header to the script

Compare with previous version

unmarked as a Work In Progress

assigned to @kkoci and unassigned @vmyslivec

resolved all threads

LGTM

added 12 commits

• 7db50d40...f525b952 - 8 commits from branch develop
• b2157001 - sentinel-proxy: Fix dependency on functions
• f2fb4e9c - sentinel-proxy: Add an info header to the script
• 4e9b69a9 - sentinel-firewall: Source OpenWrt functions only if needed
• 759f7911 - sentinel-firewall: Add an info header to the script

Compare with previous version

merged

changed the description

changed milestone to %"Turris OS 5.2"

mentioned in issue turris/sentinel/nikola#28 (closed)