sentinel.sh dependency
Main issue is in nikola crontab. sentinel.sh
is sourced there and allowed_to_run
called. Yet, config_load
and other OpenWrt functions is missing as functions.sh
is never sourced.
This proposed fix seems to me a straightforward solution, as you source what's needed to run the functions provided. Maybe there are some consequences I missed, so please double check this.
Merge request reports
Activity
changed milestone to %Turris OS 5.1
- Resolved by Karel Koci
Also,
sentinel.sh
,sentinel-functions.sh
, etc.. are interpreted via POSIX/bin/sh
, yet we usesource
. I know it works with OpenWrt busybox, but it's not so clean solution.Anyway, we should unify
source
or.
usage. Some scripts use the former, some the later.
- Resolved by Karel Koci
- Resolved by Vojtech Myslivec
It looks like you have this based on other merge request. MR request was also pointed to master but looks like it is based on develop (so I changed target). Please include change you are describing in MR message.
assigned to @vmyslivec and unassigned @kkoci
marked as a Work In Progress from bedacddb
assigned to @kkoci and unassigned @vmyslivec
added 12 commits
-
7db50d40...f525b952 - 8 commits from branch
develop
- b2157001 - sentinel-proxy: Fix dependency on functions
- f2fb4e9c - sentinel-proxy: Add an info header to the script
- 4e9b69a9 - sentinel-firewall: Source OpenWrt functions only if needed
- 759f7911 - sentinel-firewall: Add an info header to the script
Toggle commit list-
7db50d40...f525b952 - 8 commits from branch
mentioned in issue turris/sentinel/nikola#28 (closed)