Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Turris OS packages Turris OS packages
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 82
    • Issues 82
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Turris
  • Turris OS
  • Turris OS packagesTurris OS packages
  • Merge requests
  • !920

knot-resolver: enable dnstap module build by default

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon Borek requested to merge feature/knot-resolver_build_dnstap_module_by_default into develop May 09, 2022
  • Overview 4
  • Commits 2
  • Changes 2

dnstap module will be built but not loaded by default at runtime (configuration must be provided for it to be loaded). It is still possible to disable dnstap build manually using menuconfig.

"The dnstap module supports logging DNS requests and responses to a unix socket in dnstap format using fstrm framing library. This logging is useful if you need effectively log all DNS traffic."1

Adds dependency on protobuf, protobuf-c, libfstrm. Listed packages are available from OpenWrt packages, have uncomplicated manifests and while protobuf-c doesn't have a maintainer since spring 2020, all the packages (including protobuf-c) seem to be maintained - the last updates of all of them in autumn 2021.

As stated by a Knot developer they build dnstap while packaging for majority of standard Linux distributions. Therefore this change brings us closer to expected default.

Testing done:

Was successfully built by the build server and run tested on Turris Omnia and Turris Mox on current HBL branch.

  1. https://knot-resolver.readthedocs.io/en/stable/modules-dnstap.html ↩

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/knot-resolver_build_dnstap_module_by_default