Commit all changes when leaving context

pyuci.c

@@ -64,8 +64,20 @@ static PyObject *pyuci_enter(uci_object *self, PyObject *args) {
 }
 
 static PyObject *pyuci_exit(uci_object *self, PyObject *args) {
-	if (self->ctx)
+	if (self->ctx) {
+		// Commit all changes
+		struct uci_ptr ptr;
+		memset(&ptr, 0, sizeof ptr);
+		struct uci_element *e, *tmp;
+		uci_foreach_element_safe(&self->ctx->root, tmp, e) {
+			struct uci_package *p = uci_to_package(e);
+			if (ptr.p && (ptr.p != p))
+				continue;
+			ptr.p = p;
+			uci_commit(self->ctx, &p, false);
+		}
 		uci_free_context(self->ctx);
+	}
 	self->ctx = NULL;
 	Py_RETURN_NONE;
 }

tests/test_module.py

@@ -177,3 +177,17 @@ config testing 'testing'
     with uci.Uci(confdir=tmpdir.strpath) as u:
         assert u.get('test', 'testing', 'one') == '0'
         assert u.get('test', 'testing', 'two') == '1'
+
+
+def test_context_commit(tmpdir):
+    """Test that when we leave context that we commit. This depends on working
+    test_set.
+    """
+    tmpdir.join('test').write("")
+    with uci.Uci(confdir=tmpdir.strpath) as u:
+        u.set('test', 'testing', 'testing')
+        u.set('test', 'testing', 'one', '0')
+        u.set('test', 'testing', 'two', '1')
+    with uci.Uci(confdir=tmpdir.strpath) as u:
+        assert u.get('test', 'testing', 'one') == '0'
+        assert u.get('test', 'testing', 'two') == '1'