Package
Convert Certgen to package
Merge request reports
Activity
changed milestone to %Turris OS 4.0
I will mark this WIP as I have not test it yet. However if you would like to try it for yourself, go for it
(ok, i need to fix the logging
Edited by Vojtech Myslivecadded 2 commits
marked as a Work In Progress from 0ad7ecce
It's ready to review now. I have test it manually on a router and both certificate and mailpass was generated ok. Also logging works fine at the moment (it was needed to refactor the code a bit more).
However, it was not heavily tested – we need to implement automated tests for certgen ASAP.
Please review these changes.
Edited by Vojtech Myslivecmarked as a Work In Progress from ec9eafff
mentioned in merge request !11 (merged)
Resolved by Martin Prudek- Resolved by Martin Prudek
I like the split into multiple files - file names, their contents (besides constans in
__init__.py- I'm not sure there), etc...It's a shame that there is not a single commit just for splitting (logger setup was added in the same commit) so one can't be sure whether some further changes were done in this big commit (not well-arranged when code is moved between files...)
Anyway, good work. Ready to merge after solving the only and rather philosophical discussion.
Edited by Martin Prudek -
Last reply by
Martin Prudek
assigned to @vmyslivec
marked as a Work In Progress from 5f5944ff
- Resolved by Martin Prudek
assigned to @mprudek
changed milestone to %Turris OS 4.0.1
- Resolved by Martin Prudek
- Resolved by Vojtech Myslivec
- Resolved by Martin Prudek
- Resolved by Vojtech Myslivec
marked as a Work In Progress from c75b0bfb
- Resolved by Martin Prudek
marked as a Work In Progress from 5c7e39ba
- Resolved by Vojtech Myslivec
I've tested it for mailpass & certs on
- PC with atshaemul -OK
- Omnia 3.11.5 - instaleld via pip3.
Here I encountered problem with dependencies:
pkg_resources.DistributionNotFound: The 'idna<2.9,>=2.5' distribution was not found and is required by requests. I had to upgrade packageidnamanually via pip3 from 2.1 to version 2.8. Then it worked well with production server. - MOX 4.0-beta1, 0663455801 failed with:
Traceback (most recent call last): File "/usr/bin/sentinel-certgen", line 11, in <module> load_entry_point('certgen==5.0', 'console_scripts', 'sentinel-certgen')() File "/__init__.py", line 487, in load_entry_point File "/__init__.py", line 2728, in load_entry_point File "/__init__.py", line 2346, in load File "/__init__.py", line 2352, in resolve File "/usr/lib/python3.6/site-packages/certgen/__main__.py", line 11, in <module> from .cryptography import clear_cert_dir File "/usr/lib/python3.6/site-packages/certgen/cryptography.py", line 10, in <module> from cryptography.hazmat.primitives import serialization File "<frozen importlib._bootstrap>", line 971, in _find_and_load File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 665, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 674, in exec_module File "<frozen importlib._bootstrap_external>", line 887, in get_code File "<frozen importlib._bootstrap_external>", line 833, in get_data OSError: [Errno 5] I/O errorI'm not able to say whether the problems are caused by splitting the single file into modules / packaging it / installing it with pip3. But it's probably a problem of deployment rather then code. So I'd carry out bigger testing after/about merging !13 (merged)
The code itself is ready t merge.
Edited by Martin Prudek - Last reply by
Martin Prudek
assigned to @vmyslivec
changed milestone to %Turris OS 4.0
mentioned in merge request turris/user-notify!6 (merged)