Package

Convert Certgen to package

changed milestone to %Turris OS 4.0

I will mark this WIP as I have not test it yet. However if you would like to try it for yourself, go for it

(ok, i need to fix the logging )

marked as a Work In Progress

added 1 commit

• 0c23e026 - fixup! Convert script to package

Compare with previous version

added 2 commits

• d486db83 - fixup! Convert script to package
• 49a5c33b - fixup! Convert script to package

Compare with previous version

added 1 commit

• 97e0ff02 - fixup! Convert script to package

Compare with previous version

unmarked as a Work In Progress

added 1 commit

• 0ad7ecce - fixup! Convert script to package

Compare with previous version

marked as a Work In Progress from 0ad7ecce

added 2 commits

• 1a3a4bea - fixup! Convert script to package
• 67fe19ae - argparser: Add option to print certgen version

Compare with previous version

added 1 commit

• 54bdaa8f - Release version 5.0

Compare with previous version

added 1 commit

• ea849d48 - fixup! Convert script to package

Compare with previous version

added 1 commit

• 2d2b1bc1 - fixup! Convert script to package

Compare with previous version

added 1 commit

• 002368b6 - fixup! Convert script to package

Compare with previous version

unmarked as a Work In Progress

added 4 commits

• 77de5597 - Convert script to package
• 42a36094 - Add standard setup.py
• 8c585067 - argparser: Add option to print certgen version
• 188e64ee - Release version 5.0

Compare with previous version

It's ready to review now. I have test it manually on a router and both certificate and mailpass was generated ok. Also logging works fine at the moment (it was needed to refactor the code a bit more).

However, it was not heavily tested – we need to implement automated tests for certgen ASAP.

Please review these changes.

added 1 commit

• ec9eafff - fixup! Convert script to package

Compare with previous version

marked as a Work In Progress from ec9eafff

unmarked as a Work In Progress

added 4 commits

• fc7ca29d - Convert script to package
• 3ef31883 - Add standard setup.py
• 0991ea34 - argparser: Add option to print certgen version
• 4e8e4c17 - Release version 5.0

Compare with previous version

added 4 commits

• cf902176 - Convert script to package
• 12d1382a - Add standard setup.py
• ad806030 - argparser: Add option to print certgen version
• 1b994690 - Release version 5.0

Compare with previous version

mentioned in merge request !11 (merged)

added 4 commits

• 66c64291 - Convert script to package
• 5f307ae8 - Add standard setup.py
• ad575dc0 - argparser: Add option to print certgen version
• 93e3d9af - Release version 5.0

Compare with previous version

mentioned in merge request turris/turris-os-packages!86

I like the split into multiple files - file names, their contents (besides constans in __init__.py - I'm not sure there), etc...

It's a shame that there is not a single commit just for splitting (logger setup was added in the same commit) so one can't be sure whether some further changes were done in this big commit (not well-arranged when code is moved between files...)

Anyway, good work. Ready to merge after solving the only and rather philosophical discussion.

assigned to @vmyslivec

added 1 commit

• 5f5944ff - fixup! Add standard setup.py

Compare with previous version

marked as a Work In Progress from 5f5944ff

unmarked as a Work In Progress

assigned to @mprudek

changed milestone to %Turris OS 4.0.1

resolved all discussions

added 1 commit

• c75b0bfb - fixup! Convert script to package

Compare with previous version

marked as a Work In Progress from c75b0bfb

added 1 commit

• e674bcea - fixup! Convert script to package

Compare with previous version

added 1 commit

• 9dfa07be - fixup! Convert script to package

Compare with previous version

added 1 commit

• 6b546165 - fixup! Convert script to package

Compare with previous version

unmarked as a Work In Progress

added 1 commit

• 5c7e39ba - fixup! Convert script to package

Compare with previous version

marked as a Work In Progress from 5c7e39ba

unmarked as a Work In Progress

resolved all discussions