Package
Convert Certgen to package
Merge request reports
Activity
changed milestone to %Turris OS 4.0
I will mark this WIP as I have not test it yet. However if you would like to try it for yourself, go for it
(ok, i need to fix the logging
)Edited by Vojtech Myslivecadded 2 commits
marked as a Work In Progress from 0ad7ecce
It's ready to review now. I have test it manually on a router and both certificate and mailpass was generated ok. Also logging works fine at the moment (it was needed to refactor the code a bit more).
However, it was not heavily tested – we need to implement automated tests for certgen ASAP.
Please review these changes.
Edited by Vojtech Myslivecmarked as a Work In Progress from ec9eafff
mentioned in merge request !11 (merged)
- Resolved by Martin Prudek
- Resolved by Martin Prudek
I like the split into multiple files - file names, their contents (besides constans in
__init__.py
- I'm not sure there), etc...It's a shame that there is not a single commit just for splitting (logger setup was added in the same commit) so one can't be sure whether some further changes were done in this big commit (not well-arranged when code is moved between files...)
Anyway, good work. Ready to merge after solving the only and rather philosophical discussion.
Edited by Martin Prudek
assigned to @vmyslivec
marked as a Work In Progress from 5f5944ff
- Resolved by Martin Prudek
assigned to @mprudek
changed milestone to %Turris OS 4.0.1
- Resolved by Martin Prudek
- Resolved by Vojtech Myslivec
- Resolved by Martin Prudek
- Resolved by Vojtech Myslivec
marked as a Work In Progress from c75b0bfb
- Resolved by Martin Prudek
marked as a Work In Progress from 5c7e39ba