Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
M
Minipots
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 16
    • Issues 16
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • Turris
  • Sentinel
  • Minipots
  • Issues
  • #31

Closed
Open
Opened Aug 10, 2020 by Vojtech Myslivec@vmyslivec🚀Owner

Send empty password if missing

For telnet/ftp/... minipot, we check presence of both username and password data fields.

In some cases, there is missing password which raised errors such as:

Invalid message from client FOO

Both password and username must be present (empty, if needed) in login message type to make it processable on server-side.

Wrong message:

sentinel/collect/minipot: {
    'ts': 1597078735,
    'id': 'FOO',
    'device_token': 'barred',
    'type': 'ftp',
    'action': 'login',
    'data': {
        'username': 'admin'
    },
    'ip': '192.0.2.42'
}

Correct message:

sentinel/collect/minipot: {
    'ts': 1597078735,
    'id': 'FOO',
    'device_token': 'barred',
    'type': 'ftp',
    'action': 'login',
    'data': {
        'username': 'admin',
        'password': ''
    },
    'ip': '192.0.2.42'
}
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Turris OS 5.2.0
Milestone
Turris OS 5.2.0
Assign milestone
Time tracking
None
Due date
None
Reference: turris/sentinel/minipot#31