deckard.py: start the server without `start_new_session`

This hopefully prevents the daemons from hanging after ^C exit.

subprocess.Popen is now run without the start_new_session=True parameter.

According to the docs this doesn't call setsid() before forking. But I'm not sure about what other implications this change might have.

Closes: #3 (closed)

I wasn't able to get the kresd to dangle using the reproducer (https://gitlab.labs.nic.cz/knot/deckard/issues/3#note_54592) with this fix (with and without the -n argument – i.e. running in parallel). I was able to reproduce it on current master.

@pspacek can you give it a few runs on your machine? Do you see any implications from the now missing setsid()? Hopefully it at least lowers the probability of leaving the process dangling.

mentioned in issue #3 (closed)

added 22 commits

• 3b62b7be...565d0cb4 - 21 commits from branch master
• c98d00e4 - deckard.py: start the server without `start_new_session`

Compare with previous version

changed the description

Seems to work on my machine but I have admin I do not understand its implications either... anyway, it seems benign so let's merge it - we can revert anytime.

unmarked as a Work In Progress

enabled an automatic merge when the pipeline for c98d00e4 succeeds

merged

mentioned in commit e60e2ccc