Skip to content
Snippets Groups Projects
Verified Commit 69535e09 authored by Vladimír Čunát's avatar Vladimír Čunát
Browse files

daemon/zimport: close transaction after importing batch

I'm really sorry about this.  It's my regression in 5.5.0 (!1225)

Practical consequence was that the RW transaction was held open
until that instance did something with cache (and thus closed),
so any other instance would be frozen in the meantime if doing
anything non-read-only with cache (e.g. startup).
https://lists.nic.cz/hyperkitty/list/knot-resolver-users@lists.nic.cz/thread/6DOXXOA6ACEUBVYPUY3T2MLGIHWOMV6M/
parent b091d3d0
Branches
Tags
2 merge requests!1327Update manager branch with the newest changes from master,!1285daemon/zimport: close transaction after importing batch
Pipeline #97513 failed with stages
in 1 hour, 8 minutes, and 13 seconds
......@@ -5,6 +5,7 @@ Bugfixes
--------
- modules/dns64: fix incorrect packet writes for cached packets (#727, !1275)
- xdp: make it work also with libknot 3.1 (#735, !1276)
- prefill module: fix lockup when starting multiple idle instances (!1285)
Knot Resolver 5.5.0 (2022-03-15)
......
......@@ -426,6 +426,7 @@ static void zi_zone_process(uv_timer_t *timer)
kr_timer_start(&stopwatch);
int ret = trie_apply(z_import->rrsets, zi_rrset_import, z_import);
(void)kr_cache_commit(&the_worker->engine->resolver.cache); // RW transaction open
if (ret == 0) {
kr_log_info(PREFILL, "performance: validating and caching took %.3lf s\n",
kr_timer_elapsed(&stopwatch));
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment