meson: use c_args instead of setting global compiler options

client/meson.build

@@ -31,6 +31,7 @@ if build_client
       libkres_dep,
       libedit,
     ],
+    c_args: c_args,
     install: true,
     install_dir: get_option('sbindir'),
   )

contrib/meson.build

@@ -18,6 +18,7 @@ contrib_lib = static_library(
   contrib_src,
   include_directories: contrib_inc,
   dependencies: libknot,
+  c_args: c_args,
 )
 
 contrib_dep = declare_dependency(

daemon/meson.build

@@ -50,6 +50,7 @@ kresd = executable(
   kresd_src,
   dependencies: kresd_deps,
   export_dynamic: true,
+  c_args: c_args,
   install: true,
   install_dir: get_option('sbindir'),
 )

lib/meson.build

@@ -87,6 +87,7 @@ libkres_lib = library('kres',
     gnutls,
     luajit,
   ],
+  c_args: c_args,
   install: true,
 )
 

meson.build

@@ -89,8 +89,7 @@ if opt_systemd != 'disabled'
   message('---------------------------')
 endif
 
-# TODO use var instead
-add_global_arguments(
+c_args = [
   '-D_GNU_SOURCE',
   '-Wtype-limits',
   '-Wformat',
@@ -98,8 +97,7 @@ add_global_arguments(
   '-Wshadow',
   '-Wall',
   '-fvisibility=hidden',
-  language: 'c',
-)
+]
 
 # Lists of tests
 # These lists are added to from subdir() and finally used in tests/*

modules/bogus_log/meson.build

@@ -13,6 +13,7 @@ bogus_log_mod = shared_module(
     libknot,
   ],
   name_prefix: '',
+  c_args: c_args,
   install: true,
   install_dir: modules_dir,
 )

modules/dnstap/meson.build

@@ -41,6 +41,7 @@ if libprotobuf_c.found() and libfstrm.found() and protoc_c.found()
       libprotobuf_c,
     ],
     name_prefix: '',
+    c_args: c_args,
     install: true,
     install_dir: modules_dir,
   )

modules/edns_keepalive/meson.build

@@ -13,6 +13,7 @@ edns_keepalive_mod = shared_module(
     libknot,
   ],
   name_prefix: '',
+  c_args: c_args,
   install: true,
   install_dir: modules_dir,
 )

modules/hints/meson.build

@@ -14,6 +14,7 @@ hints_mod = shared_module(
     luajit,
   ],
   name_prefix: '',
+  c_args: c_args,
   install: true,
   install_dir: modules_dir,
 )

modules/nsid/meson.build

@@ -14,6 +14,7 @@ nsid_mod = shared_module(
     luajit,
   ],
   name_prefix: '',
+  c_args: c_args,
   install: true,
   install_dir: modules_dir,
 )

modules/stats/meson.build

@@ -14,6 +14,7 @@ stats_mod = shared_module(
     luajit,
   ],
   name_prefix: '',
+  c_args: c_args,
   install: true,
   install_dir: modules_dir,
 )

tests/pytests/meson.build

@@ -6,7 +6,6 @@ tlsproxy_src = [
 ]
 
 # compile tlsproxy
-# TODO fix or silence compilation warnings
 tlsproxy = executable(
   'tlsproxy',
   tlsproxy_src,
@@ -15,6 +14,7 @@ tlsproxy = executable(
     libuv,
     gnutls,
   ],
+  c_args: c_args,
 )
 
 # python 3 dependencies

tests/unit/meson.build

@@ -27,6 +27,7 @@ foreach unit_test : unit_tests
       cmocka,
       lmdb,
     ],
+    c_args: c_args,
   )
   test(
     'unit.' + unit_test[0],