CI: run installcheck tests with and without Valgrind

.gitlab-ci.yml

@@ -36,6 +36,16 @@ test:linux:amd64:
     - linux
     - amd64
 
+installcheck:linux:amd64:
+  stage: test
+  script:
+    - PREFIX=$(pwd)/.local make -k installcheck
+  dependencies:
+    - build:linux:amd64
+  tags:
+    - docker
+    - linux
+    - amd64
 
 deckard:linux:amd64:
   stage: test
@@ -48,6 +58,16 @@ deckard:linux:amd64:
     - linux
     - amd64
 
+installcheck:valgrind:linux:amd64:
+  stage: test
+  script:
+    - DEBUGGER="valgrind --leak-check=full --trace-children=yes --quiet --suppressions=/lj.supp" PREFIX=$(pwd)/.local make -k installcheck
+  dependencies:
+    - build:linux:amd64
+  tags:
+    - docker
+    - linux
+    - amd64
 
 # temporarily disabled - we need to fix issues first
 #deckard:linux:amd64:valgrind:

tests/config/runtest.sh

 #!/bin/sh -e
-export TMP_RUNDIR=`mktemp -d`
+export TMP_RUNDIR="$(mktemp -d)"
 function finish {
-  rm -rf ${TMP_RUNDIR}
+  rm -rf "${TMP_RUNDIR}"
 }
 trap finish EXIT
 
 echo "config-test: ${2}"
-cp tests/config/${2}/* ${TMP_RUNDIR}/
-cp tests/config/test_utils.lua ${TMP_RUNDIR}/
-KRESD_NO_LISTEN=1 ${1} -f 1 -c test.cfg ${TMP_RUNDIR}
\ No newline at end of file
+cp "tests/config/${2}/"* "${TMP_RUNDIR}/"
+cp tests/config/test_utils.lua "${TMP_RUNDIR}/"
+KRESD_NO_LISTEN=1 ${DEBUGGER} ${1} -f 1 -c test.cfg "${TMP_RUNDIR}"

tests/config/test_config.mk

@@ -12,7 +12,7 @@ tests_config := \
 
 define make_config_test
 test-config-$(1): tests/config/$(1)/test.cfg check-install-precond
-	@$(preload_syms) $(DEBUGGER) ./tests/config/runtest.sh $(abspath $(SBINDIR)/kresd) $(1)
+	@$(preload_syms) ./tests/config/runtest.sh $(abspath $(SBINDIR)/kresd) $(1)
 .PHONY: test-$(1)
 endef