Vitezslav Kriz authored 7 years ago and Petr Špaček committed 7 years ago

Monotonic time from libuv function uv_now (wrapped in kr_now) is
used for query timeout, stats and RTT in reputation cache.

Cache, DNSSEC Validation and Cookies use real time.

daemon: add missing RR type definitions

See merge request !416

Some RR type definitions present in IANA DNS parameters registry were
missing in kresd. This commit synchronizes the tables with IANA registry
as of 2017-12-08 13:20 UTC.

At the same time, this commit is
fixup! converted constant tables, support kres.type.TYPE1234
The mentioned commit accidentally removed NULL definition which broke TA
signaling module.

time_skew: Detect time skew during kresd start.

See merge request knot/knot-resolver!414

Without this check, the module would print warning for every single run
without root trust anchor.

Vitezslav Kriz authored 7 years ago and Petr Špaček committed 7 years ago

This module is enabled by default, but disabled in Deckard tests.

Originally division around sizeof(uint32_t) caused silent truncation
for struct kr_qflags with sizes not multiple of 4 bytes.

Attempts to optimize using uint32_t blocks could lead to read/write
beyond end of uint32_t so I'm not willing to risk it.

Also, the code was refactored to avoid duplication between _set and _clear.
Quick look into assembly produced by gcc 7.2.1 with -O2 on x86_64 confirms that
all auxiliary functions got inlined so there are not extra function calls.

Unit tests are attached. These fail on the previous version of _set() and
_clear() and work now.

CI fixups

Closes #282

See merge request knot/knot-resolver!415

Related: !405

Hopefully this will make build more reliable because breakage in Knot
DNS master will not affect us. On the other hand, we must not forget to
update Knot DNS in the image!

Closes: #282

code-style: replace `-->` in for loops with `i > 0` and `i--`

See merge request knot/knot-resolver!408

Fix confusing error messages regarding root hints

Closes #278

See merge request knot/knot-resolver!413

If user provides custom hints file with config option hints.root_file('file')
resovler fail with error. Before it just silently pass and may fail
when loading defaults file, which leads to confusing error message.

fixup! client: move sources into separate directory

See merge request knot/knot-resolver!410

Previous cleanup attempt broke installation on systems without libedit.
client-install has to be defined at least as .PHONY target.
(I want to avoid if spagethi outside of client.mk.)

Pre-2.0 cleanup

See merge request knot/knot-resolver!409

Let's not mix daemon and client files as client might grow to multiple
files in future. This will also help with upcomming changes to packaging
scripts.

The old name was confusing because module name was different than all
other names and references in manual.

The old name was confusing because module name backend name provided by
that modules were different.

It is 2017 already, so Python 3 is the default.

The script did not work under Python 3, and given broad support for
SO_REUSEPORT, it is easier to drop it than to debug it.

priming: implement priming queries as module

Closes #220

See merge request knot/knot-resolver!391

Vitezslav Kriz authored 7 years ago and Petr Špaček committed 7 years ago

Also removed priming query from trust anchor module.
Updated deckard repository.

Updated config tests, fixing code coverage for C and Lua

See merge request !403

It does not make sense to create "distribution" tarball with dirty
working tree or missing submodules, so this is now forbidden.
make-archive.sh requires clean working tree and all submodules.

Packing all submodules prevents us from releasing incomplete tarball,
especially around release time.

Distributions like Fedora are gradually getting ability to run
integration test suites so it does not hurt to pack everything including
test.

Marek Vavruša authored 7 years ago and Petr Špaček committed 7 years ago

The 2.4.0 is required as a minimum.

Marek Vavruša authored 7 years ago and Petr Špaček committed 7 years ago

Lint should always render the .lua from .lua.in files before checking.

Marek Vavruša authored 7 years ago and Petr Špaček committed 7 years ago

Currently it gathers gcov and luacov code coverage, and merges it
in a single lcov info file. It returns summary at the end which the
CI can parse and interpret. It can build a html report later using
the data.

Marek Vavruša authored 7 years ago and Petr Špaček committed 7 years ago

I moved the test files to module directories because it allows
vendoring of whole modules including tests etc.

The test environment provides convenience functions and produces
test output in TAP format. Ideally all tests should use a common
format, so that CI can parse it provide better test output on PRs.
It seems like Gitlab CI doesn't support anything yet, but there
are two sort-of standards supported in CI tools - TAP and JUnit.
I chose TAP because it's easier to read for humans, cmocka supports it,
and it should be easier to adapt Deckard. There are also tools to
convert TAP into JUnit XML file.

Also added more tests for global functions and variables, and the
test tool now also tracks coverage (if `luacov` is installed).

CI: unify Docker images for kresd and Deckard CI

See merge request !404

The Docker image now should work for both projects.
Also, the image was extended with tools to measure code coverage.

CI: add Lua lint and installcheck tests

See merge request !402

/bin/sh in our image does not support "function" keyword