This is super useful for checking things like misusing undefined
variables or modifying globals, especially in modules when it's
not immediately visible which variables are in the global
namespace and which are not.

I added several exceptions for files in daemon/lua and tests,
as for example sandbox module needs to legitimately modify
global namespace.

There's a lot of things failing, so I didn't make it part of the
standard `make check`, but we should eventually enable it to
improve code quality and spot problems with CI.

CI optimization

Closes #270

See merge request !397

See Deckard MR!85 for details.

Packages are already present in the image so we do not need to spend
time on package maintenance.

For now I didn't touch the generator to be correct on this line,
as we will probably want to change it after bumping minimal libknot
version.

I'm sorry. Buggy commit: 2ba2a5e8

It's very unlikely to happen - sum of string lengths overflowing -
even on a 32-bit platform, and the input seems not controllable by
adversaries, but let's fix it anyway.

Fix check target (check-config requires installed version of kresd)

Closes #272

See merge request !389

Path to module directory gets hardcoded into binaries so check-config
and check-integration cannot work prior installation.

To indicate this depedency, the target check-config was moved from
"check" target to "installcheck".

Deckard requires additional libraries so it is not included in
installcheck.

fixes: #272

Previously it might happen that installed libraries
had higher priority over libraries in build directory.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878976
In general, platforms with page size other than 4k might better compile
with -DCPU_PAGE_SIZE=nnnnn but real impact should only be this test and
better alignment in the mempool allocator.

We can ignore the signal, as the affected libuv calls report error
by returning EPIPE anyway.
Fixes https://gitlab.labs.nic.cz/knot/knot-resolver/issues/271

Add note about initializing submodules needed to build successfully.

See merge request !387

attempt validation for more records but require it for fewer of them
(e.g. avoids SERVFAIL when server adds extra records but omits RRSIGs)

attempt validation for more records but require it for fewer of them
(e.g. avoids SERVFAIL when server adds extra records but omits RRSIGs)

Vitezslav Kriz authored 7 years ago and Petr Špaček committed 7 years ago

Implementation of RFC 8145 section 5 as module.

Fixes: #383

fixup! Signaling Trust Anchor Knowledge in DNSSEC using Key Tag Query

systemd: drop RefuseManualStart=true, disable kresd.service by default

See merge request !380

This allows the socket to be bound before the network interface comes
up, which is preferable to having a race between the interface coming
up and the socket being bound.

I introduced RefuseManualStart=true last year when writing the initial
systemd unit file for kresd.  I did this because i didn't want to
start running the daemon if no one was going to talk to it.

I'm no longer convinced that this directive has a good justification.
While i think that there is no need to activate the service without
socket activation, i think preventing manual invocation is actively
harmful (admins will reflexively do "systemctl restart kresd" just
like they do "systemctl restart apache2" and it's jarring to have it
rejected).

A distributor who wants to (by default) delay kresd startup until it
is accessed can ship the preset file included here, but leave the
*.socket units enabled by default.

roothints: fix segfault with hints.root_file, added test

See merge request !378