Some rules need it and it was nil until now.

DENY, DENY_MSG, DROP, REFUSE and TC will now clear the _selected RRs.
I believe that's what people usually expect of these actions anyway.

Previously, all those actions caused resolver to return SERVFAIL,
because the lua code failed to evaluate.

Notably, deny action now properly returns NXDOMAIN instead of SERVFAIL.
The drop action still returns SERVFAIL.

Petr Špaček authored 5 years ago and Tomas Krizek committed 4 years ago

Old favicon used Knot DNS colors (dark blue) instead of Knot Resolver
colors (light blue).

Petr Špaček authored 5 years ago and Tomas Krizek committed 4 years ago

Rule ID is a number, not a string.

Petr Špaček authored 5 years ago and Tomas Krizek committed 4 years ago

consensus() function is affected by
https://gitlab.labs.nic.cz/knot/knot-resolver/issues/554
so this fix helps only with single-instance scenarios.

Petr Špaček authored 5 years ago and Tomas Krizek committed 4 years ago

It is broken at least since 1223599d,
i.e. 4.0.0.

realPy authored 5 years ago and Tomas Krizek committed 4 years ago

The id rule is not the same as the index of the array.

Fixes: #553

This new approach uses per-request variables in Lua and creates new
callback for each DEBUG_IF call instead of each request.

It creates new callback functions for every request which
uses "callback chaining" but these should be rare.

It seems there is no reason to keep this function private in policy
module.

DEBUG_IF accepts user-supplied function which decides which requests
should be logged.

Attempt to avoid duplicating ten lines in debug_logfinish_cb lead me
to splitting kr_log_qverbose_impl into two functions kr_log_q and kr_log_req.
This is another minor change to API exposed to modules.

Formerly both logs used slightly different formats and duplicated code.
From now on verbose log and request tracing are generated using the same
code.

This required a small change to request trace_log_f definition so it
might affect external modules.

Reported on Turris forums:
https://forum.turris.cz/t/dns-over-tcp-just-a-single-transaction/12003/21

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Source is
git+https://github.com/twbs/bootstrap.git@a78dc3aed640a35914361b837ce24573a0515e19#yeti/bootstrap.min.css
but our version has minor modifications:
- removed link to font file
- minor font and line height adjustments
- added SPDX header

Diffing minimized CSS file is a mess so use something like
$ awk '{gsub(/{|}|;/,"&\n"); print}'
to get something more legible.

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Originally we used version 0.12.0 but the files in our repo did not
exactly match files in the upstream repo and I could not confirm
if the changes were meaningful or just artifact of source minimization
process.

To remove uncertainity I've updated selectize.js to latest upstream version
0.12.6, did not do any extra CSS minimization, and removed unused file
selectize.min.css.

As far as I can tell it seems to work.

Source:
git+https://github.com/selectize/selectize.js.git@eb0fca364f9bd6864ae197ea58c853f2717052a9

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

The SPDX file contains hand-written metadata about source URL, version,
authors, and license.

There are two missing pieces in HTTP module:
- bootswatch theme - I could not find what theme we ship, maybe it is
  based on one of bootswatch themes but heavily modified
- selectize.js source does not match respective files in upstream but
  contains minor changes

I will deal with these in later commits.

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

https://www.kernel.org/doc/html/latest/process/license-rules.html#license-identifier-syntax