Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Regression in 19ef77d1 (unreleased): Default value IN for qclass
parameter was missing.  Also consistently use A as default for qtype.

Thanks to changes in this branch the functions are called with correctly
typed parameters already, so these weird casts can be deleted.

We're very much depending on LuaJIT, for years already.
The removed stuff seems very unlikely to be useful in any LuaJIT
in forseeable future.  The Lua language is effectively forked.

... without light userdata and yet it should be efficient.
Also with checkout layer, but I have no nice way of testing that one.

In particular, throw errors when used in weird ways,
instead of the usual "return nil" semantics.
That might be surprising to some lua users.

...when making calls from lua to C modules; use luaJIT FFI instead.
This eliminates some cases of lua_pushlightuserdata().

On many places we've been assuming that there's only a single worker,
but we still often didn't utilize the property well.  To get the pointer
we used various ways, all even untyped:
 - __worker global variable in lua
 - uv_default_loop()->data
 - kr_request::daemon_context

Now we instead simply define a global typed pointer the_worker.

Nitpick: also worker_{init,deinit}() are reordered to correspond
to the order of the fields, etc.

Now we hopefully won't need to touch it for a long time.

It gets handy for debugging, especially when looking at dufferent
callback "instances".

It would be pointless anyway as it cannot provide more information.

As far as I understand the debug.sethook('call') descrption we are not
going to have any locals except function parameters so we can simplify
the code.

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

"Unfortunately", for FFI-bound C functions there it doesn't hold that
missing parameters would be converted to nil/NULL.
Still, this function seems unlikely to have been used outside the repo.

Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

It caused crashes somewhere inside LuaJIT or the JIT-ed code.

This will allow modules like view etc. work in the same way with packets
received over HTTP.

First version which actually works with Firefox DoH in default
configuration.

Limitations:
- does not support HTTP GET method
- headers for HTTP cache are not generated
- error handling is largely missing
- no tests
- ACLs will not work, modules do not see source IP address of the HTTP
endpoint

This does not work with C functions etc. but it seems that we do not
expose them directly in Lua interface for users.

This makes it much easier to navigate in complex data structures.
AFAIK table_print is not used for anything except user interface so it
is not performance critical and we can re-sort table every time.

User-friendly error message is intentionally at the end so users,
typically looking at the last line in logs, can see immediatelly what
happened.

Previous version would add the TA and then print error message, which is
not expected.