This filtering was dropped in 4565cc59 (v5.3.0).
Now it's reintroduced - but inside the function, as that seems nicer.
Nit: naming and comment were updated to fit the current usage.

As the code is designed so far (in whole history probably), in order
to detect whether we need to choose a zone cut closer to the root,
we need to do something like this in lib/zonecut.c already,
instead of just during server selection.

I don't think this change can break anything.
Fetching unusable addresses from cache seems pointless,
as selection wouldn't be allowed to use them or try resolving them.

NEWS: improve the security entry in 5.7.0

See merge request knot/knot-resolver!1468

doc: upgrading guide to version 6

See merge request !1466

Lua config moved to developers chapter as internal Lua config.

- move typical simple examples near the top
- document the two new conditions
- reorganize the text: split conditions and actions
- other minor changes

It seems such an edge case that I chose to avoid the issue this way.

The issue is not now; it has always been broken in 6.x.
The model is that at most one view applies on any request.
If we need to do more things, they must happen as one meta-action.

test_view_insert_action(): dropped; can't see a suitable replacement

Examples:
 - tagging based on dst_subnet is useful for providing different
   filtering setting on different resolver addresses
 - tagging based on protocols is useful to signal used transport
   (change in DNS data that can be read by the final app)

(docs added in a later commit)

This doesn't yet search among the multiple values.
The rules/api parts that write rules were adapted or commented on.

They're a bit more efficient, but they can't work with LMDB multi-sets.
Also, write performance of rules isn't that important and typically
each rule is quite tiny anyway.

At least I hope this will work as expected.

Vladimír Čunát authored 1 year ago and Oto Šťáva committed 1 year ago

This will allow it to work even when socket is elsewhere.
The service depended on fixed config file location already,
through ExecStart.

Vladimír Čunát authored 1 year ago and Oto Šťáva committed 1 year ago

Propagate errors, fix nit reported by shellcheck.

Aleš Mrázek authored 1 year ago and Oto Šťáva committed 1 year ago

- interface and unix_socket validation