Vladimír Čunát authored 5 years ago and Petr Špaček committed 5 years ago

- don't print a line in every checking cycle
- don't exit when cache isn't found
- reduce recommended interval to 10s (compromise)
- don't increase cache size (but keep the code for now)

Petr Špaček authored 5 years ago and Vladimír Čunát committed 5 years ago

Regression in 19ef77d1 (unreleased): Default value IN for qclass
parameter was missing.  Also consistently use A as default for qtype.

Thanks to changes in this branch the functions are called with correctly
typed parameters already, so these weird casts can be deleted.

Theoretically a lua module could have used them, but I see no motivation
for that, as they have much more convenient ways inside lua.

... when called with bad parameters, and restructure the code a bit.
Note: uv_timer_start() is documented to be OK on active timers.

They're a bit more expensive, but we won't want lots of events anyway,
so I decided to do a simple conversion.

We're very much depending on LuaJIT, for years already.
The removed stuff seems very unlikely to be useful in any LuaJIT
in forseeable future.  The Lua language is effectively forked.

... without light userdata and yet it should be efficient.
Also with checkout layer, but I have no nice way of testing that one.

In particular, throw errors when used in weird ways,
instead of the usual "return nil" semantics.
That might be surprising to some lua users.

...when making calls from lua to C modules; use luaJIT FFI instead.
This eliminates some cases of lua_pushlightuserdata().

On many places we've been assuming that there's only a single worker,
but we still often didn't utilize the property well.  To get the pointer
we used various ways, all even untyped:
 - __worker global variable in lua
 - uv_default_loop()->data
 - kr_request::daemon_context

Now we instead simply define a global typed pointer the_worker.

Nitpick: also worker_{init,deinit}() are reordered to correspond
to the order of the fields, etc.

There's no support for the "dns" and "tls" kinds (for now).

Tested briefly:
> modules = { 'http' }
> net.listen('/tmp/kresd-socket', nil, { kind = 'webmgmt' })
$ socat TCP-LISTEN:5555,reuseaddr,fork UNIX-CLIENT:/tmp/kresd-socket
$ xdg-open http://127.0.0.1:5555

See the added comments.  Such bugs are tricky, because the old code
would typically work just fine, only if libuv/OS decided to postpone
copying the data (perhaps large load), we would send two bytes from
this address on C stack - their later value (hard to predict what).

Security risks: the two bytes might theoretically contain information
that was more or less private and we just send it to some DNS server
(possibly over unencrypted TCP), but ATM I find it very unlikely that
this bug could be practically exploited.

- generate most of it from source
- make order the same in implementation and description

Now we hopefully won't need to touch it for a long time.