lib/selection: be more careful with RO transactions

See merge request !1184

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

They probably couldn't hang open for long, as each client request
should cause some cache-searching and thus close it, and even with
queries stopping I haven't managed to find a case where it would be
left open but... it's nicer to clean up and it should be very cheap.

daemon/worker: fix a memory leak

See merge request !1182

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Discovered case: TCP write towards upstream fails due to ECONNRESET,
and on this place of code we "forget" the whole qr_task and thus its
corresponding kr_request, so it remains unanswered and using memory.

ci: allow failure of CentOS 8 packaging tests

See merge request !1185

Once again there's an issue with libuv-devel. Since the distro is EOL in
6 months, I'm not going to waste effort with investigating or fixing it.

meson: disable assertions

See merge request !1183

Make sure assertions are turned off - we use our own mechanism
(implemented in !1146), so this mostly affects foreign code, like Knot
DNS headers.

!1146 (comment 203044)

distro: add apkg support

See merge request !1178

rename kind="doh" to kind="doh_legacy"

See merge request !1180

The purpose of this change is to make it harder to accidentally use the
legacy DoH implementation and free up the "doh" kind which may be used
as an alias to a modern implementation in the future.

lib/utils: define kr_require(), kr_assume() macros

Closes #495

See merge request !1146

To (hopefully) improve readability, rename the typical macro usage of:

    if (!kr_assume(x)) y; // to
    if (kr_fails_assert(x)) y;

As a convenience, replace the assert without a return value to a more
simple version:

    (void)!kr_assume(x);  // becomes
    kr_assert(x);

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Trying to handle the NULL here was pointless, so let's simplify.
As it was, it couldn't trigger anyway (would crash earlier).

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

It's a little more verbose, but it should be more valuable in case
we encounter them.

Vladimír Čunát authored 3 years ago and Tomas Krizek committed 3 years ago

Default 5 minutes (but off).
Randomize the delays +-25%.

- add lua options debugging.assumption_abort and
  debugging.assumption_fork to make the behaviour configurable
- select default values based on meson buildtype:
  - debug/debugoptimized (default, e.g. used in CI) - abort and don't
    fork
  - plain/release - don't abort, but fork if abort is user-configured