ci: check whether Deckard submodule commit is present on master
This is to prevent issues like !1036 (merged)
See https://gitlab.nic.cz/knot/knot-resolver/-/jobs/418047 for an example of an mistake caught by this check.
Merge request reports
Activity
- Resolved by Vladimír Čunát
added 5 commits
-
64f6cc97...38f7483c - 4 commits from branch
master
- 1425787f - ci: check whether Deckard submodule commit is present on master
-
64f6cc97...38f7483c - 4 commits from branch
- Resolved by Štěpán Balážik
One practical issue I commonly face is that I have some WIP and want to run full CI, but the deckard fix isn't suitable for merge yet, even though it might pass already. Currently it's enough to push the commit to deckard repo under any branch (so submodule fetch succeeds).
For that case it would be nice if this
deckard_commit
didn't block further CI steps but it certainly should block merging (make the button red) – I expect the easiest way would be to move it to the "extended" stage... but I can always do some work-around like disabling it temporarily in the MR, and maybe some general way would be better (like a CI variable causing it to run all jobs regardless of failures).
added 1 commit
- dfd2fa3e - fixup! ci: check whether Deckard submodule commit is present on master
marked as a Work In Progress from dfd2fa3e
added 1 commit
- dbeac17c - fixup! ci: check whether Deckard submodule commit is present on master
added 1 commit
- e5c2f2ab - ci: check whether Deckard submodule commit is present on master
enabled an automatic merge when the pipeline for e5c2f2ab succeeds
mentioned in commit e645ea0c