Rework iterate.c/selection.c error handling

Workarounds and error handling is now centralized in selection.c:error. The workarounds are now applied more granularly and making eventual changes (making it more strict/loose) should now be easier.

Oh, and SAFEMODE is no more. Fixes #640 (closed).

added 4 commits

• d6db53ce - iterate: rework error handling from iterate.c
• e3ac689b - selection: minor fixes in commented code
• 5ea6762f - selection: better error messages for errors
• 6350e9c1 - selection: fix DNSSEC_BOGUS/NSNXAttack mitigation interaction

Compare with previous version

marked this merge request as draft

marked this merge request as ready

added 11 commits

• 6350e9c1...1229af70 - 7 commits from branch master
• bd8d482e - iterate: rework error handling from iterate.c
• b2820477 - selection: minor fixes in commented code
• dd0c99bd - selection: better error messages for errors
• b164d47a - selection: fix DNSSEC_BOGUS/NSNXAttack mitigation interaction

Compare with previous version

I'm happy with this now. I'll schedule some respdiff runs over the weekend since the results I have seen over past days varied greatly.

added 2 commits

• f80f26f9 - fixup! iterate: rework error handling from iterate.c
• 6ab52bbf - fixup! selection: better error messages for errors

Compare with previous version

marked this merge request as draft from f80f26f9

added 1 commit

• ac9bdd03 - fixup! iterate: rework error handling from iterate.c

Compare with previous version

added 13 commits

• ac9bdd03...e6324fce - 6 commits from branch master
• d1145f89 - iterate: rework error handling from iterate.c
• 13a56044 - selection: minor fixes in commented code
• fdbbcc18 - selection: better error messages for errors
• 6c3d17e7 - selection: fix DNSSEC_BOGUS/NSNXAttack mitigation interaction
• bf5cac78 - fixup! iterate: rework error handling from iterate.c
• c3586b7c - fixup! selection: better error messages for errors
• e276522c - fixup! iterate: rework error handling from iterate.c

Compare with previous version

resolved all threads

The code diff looks good to me now. The main remaining thing would be looking at respdiffs; perhaps some multi-run of iter.* from a moment when situation seems "stable" on the internet.

added 1 commit

• 7b6486fc - fixup! iterate: rework error handling from iterate.c

Compare with previous version

added 1 commit

• 59544f1a - iterate.c: don't copy NO_MINIMIZE when following a CNAME

Compare with previous version

added 1 commit

• d5f83d83 - fixup! iterate: rework error handling from iterate.c

Compare with previous version

• remove NO_THROTTLE flag or use it properly

The flag disabled the exclusion of timeouted servers before !1030 (merged) for some queries (those going to root zone, for example). After the MR, it's set but basically never read from.

added 1 commit

• 8dbc0702 - WIP: trigger serve stale on NSNXAttack mitigation from kr_resolve_consume

Compare with previous version

added 1 commit

• c13705d5 - fixup! WIP: trigger serve stale on NSNXAttack mitigation from kr_resolve_consume

Compare with previous version

added 2 commits

• 7fa430b4 - bogus_log: fix bogus_log test to new error handling
• c1c2b32b - fixup! iterate.c: don't copy NO_MINIMIZE when following a CNAME

Compare with previous version