various refactoring
- Nov 03, 2021
-
-
-
NSEC* params were not being stashed by this function. For prefilling it's useful, but doing it on *every* NSEC* record would be quite a waste, so we introduce a parameter to select this. Implementation: there were good reasons not to implement this until needed - it wasn't straightforward at all.
-
It was a bit weird that the API had mempool creation but no deletion.
-
Also be more careful about rounding, overflows and assertions in there. The implicit internal timer was unused and didn't seem worth keeping.
-
The POSIX APIs using `struct timeval` are deprecated anyway in favor of clock_gettime() + `struct timespec`. The function didn't seem well designed anyway, as `long` is just 32-bit on usual 32-bit platforms, which certainly isn't safe. (roughly one month, on a quick glance)
-
