Skip to content
Snippets Groups Projects

lib/selection: improve IPv6 avoidance if broken + debug logs

Merged lib/selection: improve IPv6 avoidance if broken + debug logs
selection-no6-bis2 into master
Merged Vladimír Čunát requested to merge selection-no6-bis2 into master
Viewing commit f9d75a16
Prev
Show latest version
3 files
+ 26
− 5
Preferences
Compare changes
Files
3
  • f9d75a16 
    And that made the "NO6: is KO" line extraneous.
Example in context:
[select][14162.01]   => id: '15271' choosing from addresses: 0 v4 + 1 v6; names to resolve: 6 v4 + 5 v6; force_resolve: 0; NO6: IPv6 is OK
[select][14162.01]   => id: '15271' choosing: 'ns1.p31.dynect.net.'@'2600:2000:2210::31#00053' with timeout 774 ms zone cut: 'amazon.com.'
[select][14162.01]   => id: '15271' updating: 'ns1.p31.dynect.net.'@'2600:2000:2210::31#00053' zone cut: 'amazon.com.' with rtt 316 to srtt: 311 and variance: 89
lib/selection.c
+ 1
− 3
@@ -76,7 +76,7 @@ static struct {
uint8_t addr_prefixes[NO6_PREFIX_COUNT][NO6_PREFIX_BYTES];
} no6_est = { .len_used = 0 };
static inline bool no6_is_bad(void)
bool no6_is_bad(void)
{
return no6_est.len_used == NO6_PREFIX_COUNT;
}
@@ -459,8 +459,6 @@ struct kr_transport *select_transport(const struct choice choices[], int choices
/* "EXPLOIT":
* choose a resolved address which seems best right now. */
chosen = best;
if (no6_is_bad())
VERBOSE_MSG(NULL, "NO6: is KO [exploit]\n");
}
/* Don't try the same server again when there are other choices to be explored */