Skip to content
Snippets Groups Projects

daemon/worker: drop caching of kr_request mempools

Merged Vladimír Čunát requested to merge memory-frag into master
All threads resolved!

This caused a huge increase in real memory usage in case of queries arriving to kresd while being disconnected from internet. The usage was slowly creeping up, even over 2G.

Interesting past commits: b350d38d and two preceding.

There apparently was no real memory leak. I assume that reusal of long-living mempools is risky in terms of memory fragmentation, though the extent of the issue surprised me very much. The issue seemed the same with normal glibc and jemalloc.

I generally dislike ad-hoc optimization attempts like these freelists. Now the allocator can better decide itself how to reuse memory.

Merge request reports

Pipeline #103028 failed

Pipeline failed for 17815ff3 on memory-frag

Approval is optional

Merged by Vladimír ČunátVladimír Čunát 2 years ago (Aug 11, 2022 9:57am UTC)

Pipeline #103192 failed

Pipeline failed for a4f522b8 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply