Fix building on Cygwin

Implements #781 (closed), adapted from https://github.com/CZ-NIC/knot-resolver/pull/86

mentioned in issue #781 (closed)

Won't link. hints, nsid and policy modules need luajit. i updated https://github.com/CZ-NIC/knot-resolver/pull/86

Any update on this?

added 6 commits

• 7889ec48...8c94968e - 4 commits from branch master
• 15742580 - Revert "meson: use correct luajit includes from pkgconfig"
• d70330b1 - Fix building on Cygwin

Compare with previous version

marked this merge request as ready

approved this merge request

OK. I squashed the additional changes from you and looked at the whole again, and I think this part is fine and straightforward.

added 1 commit

• 64e08c10 - add a NEWS item for these "cygwin changes"

Compare with previous version

looks fine to me. not sure if intentional but the date in the new version in NEWS looks wrong (perhaps it gets formatted later?)

As an experiment, GitHub Actions seemed to be relatively practical to do Windows builds, and with Cygwin it wasn't that complicated: https://github.com/CZ-NIC/knot-resolver/actions/runs/4312879688 The result won't just work in a cygwin installation with required dependencies, most likely because dependencies also need patches, as you linked (lmdb logged issues on a quick try).

Still, in this state the action should be able to at least detect compile-time issues, e.g. those fixed in this MR. It could surely get modified to patch whatever is required as well, but I don't feel sufficiently motivated for this.

added 5 commits

• 64e08c10...1bfae941 - 2 commits from branch master
• 6017a440 - Revert "meson: use correct luajit includes from pkgconfig"
• 92d20c97 - Fix building on Cygwin
• 7cd31c26 - add a NEWS item for these "cygwin changes"

Compare with previous version

resolved all threads

added 3 commits

• 2b6df073 - Revert "meson: use correct luajit includes from pkgconfig"
• 1b302abd - Fix building on Cygwin
• 78cec11b - add a NEWS item for these "cygwin changes"

Compare with previous version

merged

mentioned in commit 7c5a91a6

fantastic, thanks!