Skip to content
Snippets Groups Projects

Protocol layers and other parts refactoring (+ nits)

Merged Oto Šťáva requested to merge nits into master
All threads resolved!

See commits

Merge request reports

Pipeline #126257 waiting for manual action

Pipeline: Knot Resolver

#126258

    Pipeline waiting for manual action for 4d57c638 on nits

    Deployed to docs-dev‎elop/nits‎ 10 months ago
    Approved by

    Merged by Oto ŠťávaOto Šťáva 10 months ago (Jun 4, 2024 3:32pm UTC)

    Pipeline #126337 passed

    Pipeline passed for bd5d4801 on master

    Deployed to OBS/knot-re‎solver-devel‎ 10 months ago
    Deployed to docs-deve‎lop/master‎ 10 months ago

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Oto Šťáva added 1 commit

    added 1 commit

    • 68b3fab9 - fixup! daemon, lib: unify protolayer_grp and kr_proto enums

    Compare with previous version

  • Oto Šťáva resolved all threads

    resolved all threads

  • Oto Šťáva added 3 commits

    added 3 commits

    • efae3888 - daemon, lib: unify protolayer_grp and kr_proto enums
    • e1496725 - Merge branch 'master-5'
    • a8d9450a - daemon/session2: protocol layer refactors + docs

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 69913d51 - daemon/proxyv2: move PROXY protocol into its own layer

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • f60367f9 - daemon/session2: add a value into the DoQ array to avoid errors

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • cca75c40 - daemon/session2: remove cast from compile-time constant

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 1686fe3e - daemon/session2: support multiple short-lived buffers

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 0c00a564 - daemon: merge protolayer_manager and session2 into one struct

    Compare with previous version

  • Oto Šťáva marked this merge request as ready

    marked this merge request as ready

  • Oto Šťáva added 16 commits

    added 16 commits

    • 0c00a564...5c6ca32b - 7 commits from branch master
    • 33218b8a - utils/client/.clang-tidy: remove
    • b96396e5 - daemon/http: fix typo
    • 152c8ccc - daemon/io: remove minor inefficiency
    • 6376d7e3 - daemon/session2: documentation improvements
    • 436f228b - daemon, lib: unify protolayer_grp and kr_proto enums
    • 20981b6a - daemon/session2: protocol layer refactors + docs
    • bd571878 - daemon/proxyv2: move PROXY protocol into its own layer
    • eda967fe - daemon/session2: support multiple short-lived buffers
    • c2c69937 - daemon: merge protolayer_manager and session2 into one struct

    Compare with previous version

  • Oto Šťáva requested review from @vcunat

    requested review from @vcunat

  • I've passed through all of the commit diffs and noticed nothing wrong. But some kinds of errors could be missed. Really lots of lines have changed.

  • Oto Šťáva changed title from Nits to Protocol layers and other parts refactoring (+ nits)

    changed title from Nits to Protocol layers and other parts refactoring (+ nits)

  • Oto Šťáva added 1 commit

    added 1 commit

    • bda116f9 - amend! daemon/session2: support multiple short-lived buffers

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • d7d8fead - amend! daemon/proxyv2: move PROXY protocol into its own layer

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • b69ead10 - amend! daemon/proxyv2: move PROXY protocol into its own layer

    Compare with previous version

  • Oto Šťáva added 2 commits

    added 2 commits

    • 2a757895 - .clang-tidy: add quotation marks to avoid YAML parse errors
    • 9a9ce1f1 - Some more Clang-Tidy silencing

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • ab343f1f - Some more Clang-Tidy silencing

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 0f8f0be6 - Some more Clang-Tidy silencing

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 99009219 - .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva marked this merge request as draft

    marked this merge request as draft

  • Oto Šťáva added 18 commits

    added 18 commits

    • 99009219...6241c371 - 7 commits from branch master
    • 080d05a6 - 1 earlier commit
    • 52a767c6 - daemon/http: fix typo
    • d50ba83b - daemon/io: remove minor inefficiency
    • bfe6b008 - daemon/session2: documentation improvements
    • 6483ce1a - daemon, lib: unify protolayer_grp and kr_proto enums
    • 8fa91a73 - daemon/session2: protocol layer refactors + docs
    • 195736cb - daemon/proxyv2: move PROXY protocol into its own layer
    • 9c43619d - daemon/session2: optimize allocations
    • 9465e1ef - Some more Clang-Tidy silencing
    • c8a51d1c - daemon/session2: fix asynchronous layer iterations
    • b89bb8e5 - .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • d694af29 - .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 5c59f588 - .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 4bd8bc19 - .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 9df6b23e - .gitlab-ci: use Arch for linting

    Compare with previous version

  • mentioned in merge request knot-resolver-ci!1 (merged)

  • Oto Šťáva added 1 commit

    added 1 commit

    • 94ee9bef - .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 7e68b12f - .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva resolved all threads

    resolved all threads

  • Author Maintainer

    Alright. A few more things happened here since the last comment - the more serious ones are in new commits. Some commits were fixed-up, because there were typos (namely, I for some reason managed to use mm_ctx_init() which uses malloc/free instead of the mm_ctx_mempool(), which makes an actual memory pool - that would be some ugly memory leaks).

    There were a few bugs in protolayers pointed out to me by @lukas.ondracek, so I (hopefully) fixed them. I'm going to do a final rebase of his commits from rrl-wip-broken and put that into rrl-wip-unbroken, resolving all conflicts, once this is merged. If there are further bugs, I'll address them separately.

    So, I believe this is just waiting for the merge of knot-resolver-ci!1 (merged), plus a tag in that repo.

    Edited by Oto Šťáva
  • Oto Šťáva added 1 commit

    added 1 commit

    • e6f3f6ba - daemon/session2.h: clarify `struct session2` docs

    Compare with previous version

  • added 1 commit

    • ea08294b - fixup! .gitlab-ci: use Arch for linting

    Compare with previous version

  • Vladimír Čunát
  • Oto Šťáva added 2 commits

    added 2 commits

    • 3ea081d7 - fixup! Some more Clang-Tidy silencing
    • 5b0e3472 - amend! daemon/proxyv2: move PROXY protocol into its own layer

    Compare with previous version

  • Vladimír Čunát resolved all threads

    resolved all threads

  • Oto Šťáva added 15 commits

    added 15 commits

    • 5b0e3472...2c5d0df2 - 3 commits from branch master
    • 2c5d0df2...9468c57e - 2 earlier commits
    • eb92b181 - daemon/io: remove minor inefficiency
    • 350e7835 - daemon/session2: documentation improvements
    • 870dc3a7 - daemon, lib: unify protolayer_grp and kr_proto enums
    • dfe44a99 - daemon/session2: protocol layer refactors + docs
    • b475d004 - daemon/proxyv2: move PROXY protocol into its own layer
    • 9f6042c3 - daemon/session2: optimize allocations
    • a805ad63 - Some more Clang-Tidy silencing
    • 0a1f0024 - daemon/session2: fix asynchronous layer iterations
    • 08b57521 - .gitlab-ci: use Arch for linting
    • 313ddefd - daemon/session2.h: clarify `struct session2` docs

    Compare with previous version

  • Oto Šťáva added 1 commit

    added 1 commit

    • 78add1dd - fixup! .gitlab-ci: use Arch for linting

    Compare with previous version

  • Oto Šťáva marked this merge request as ready

    marked this merge request as ready

  • Oto Šťáva added 2 commits

    added 2 commits

    • 68688fac - .gitlab-ci: use Arch for linting
    • 4d57c638 - daemon/session2.h: clarify `struct session2` docs

    Compare with previous version

  • Oto Šťáva mentioned in commit bd5d4801

    mentioned in commit bd5d4801

  • Please register or sign in to reply
    Loading