Protocol layers and other parts refactoring (+ nits)
See commits
Merge request reports
Activity
- Resolved by Oto Šťáva
added 1 commit
- 68b3fab9 - fixup! daemon, lib: unify protolayer_grp and kr_proto enums
added 1 commit
- 69913d51 - daemon/proxyv2: move PROXY protocol into its own layer
added 1 commit
- f60367f9 - daemon/session2: add a value into the DoQ array to avoid errors
added 1 commit
- cca75c40 - daemon/session2: remove cast from compile-time constant
added 1 commit
- 1686fe3e - daemon/session2: support multiple short-lived buffers
added 1 commit
- 0c00a564 - daemon: merge protolayer_manager and session2 into one struct
added 16 commits
-
0c00a564...5c6ca32b - 7 commits from branch
master
- 33218b8a - utils/client/.clang-tidy: remove
- b96396e5 - daemon/http: fix typo
- 152c8ccc - daemon/io: remove minor inefficiency
- 6376d7e3 - daemon/session2: documentation improvements
- 436f228b - daemon, lib: unify protolayer_grp and kr_proto enums
- 20981b6a - daemon/session2: protocol layer refactors + docs
- bd571878 - daemon/proxyv2: move PROXY protocol into its own layer
- eda967fe - daemon/session2: support multiple short-lived buffers
- c2c69937 - daemon: merge protolayer_manager and session2 into one struct
Toggle commit list-
0c00a564...5c6ca32b - 7 commits from branch
requested review from @vcunat
- Resolved by Vladimír Čunát
Nit: if I read it right, the proxyv2 commit also removes PROTOLAYER_PAYLOAD_BUFFER support from tcp unwrap. That might be worth noting in the commit message, as it's hard to see due to the code being moved.
added 1 commit
- bda116f9 - amend! daemon/session2: support multiple short-lived buffers
added 1 commit
- d7d8fead - amend! daemon/proxyv2: move PROXY protocol into its own layer
added 1 commit
- b69ead10 - amend! daemon/proxyv2: move PROXY protocol into its own layer
added 18 commits
-
99009219...6241c371 - 7 commits from branch
master
- 080d05a6 - 1 earlier commit
- 52a767c6 - daemon/http: fix typo
- d50ba83b - daemon/io: remove minor inefficiency
- bfe6b008 - daemon/session2: documentation improvements
- 6483ce1a - daemon, lib: unify protolayer_grp and kr_proto enums
- 8fa91a73 - daemon/session2: protocol layer refactors + docs
- 195736cb - daemon/proxyv2: move PROXY protocol into its own layer
- 9c43619d - daemon/session2: optimize allocations
- 9465e1ef - Some more Clang-Tidy silencing
- c8a51d1c - daemon/session2: fix asynchronous layer iterations
- b89bb8e5 - .gitlab-ci: use Arch for linting
Toggle commit list-
99009219...6241c371 - 7 commits from branch
mentioned in merge request knot-resolver-ci!1 (merged)
Alright. A few more things happened here since the last comment - the more serious ones are in new commits. Some commits were fixed-up, because there were typos (namely, I for some reason managed to use
mm_ctx_init()
which usesmalloc/free
instead of themm_ctx_mempool()
, which makes an actual memory pool - that would be some ugly memory leaks).There were a few bugs in protolayers pointed out to me by @lukas.ondracek, so I (hopefully) fixed them. I'm going to do a final rebase of his commits from
rrl-wip-broken
and put that intorrl-wip-unbroken
, resolving all conflicts, once this is merged. If there are further bugs, I'll address them separately.So, I believe this is just waiting for the merge of knot-resolver-ci!1 (merged), plus a tag in that repo.
Edited by Oto Šťávaadded 1 commit
- e6f3f6ba - daemon/session2.h: clarify `struct session2` docs
- Resolved by Vladimír Čunát
added 15 commits
-
5b0e3472...2c5d0df2 - 3 commits from branch
master
- 2c5d0df2...9468c57e - 2 earlier commits
- eb92b181 - daemon/io: remove minor inefficiency
- 350e7835 - daemon/session2: documentation improvements
- 870dc3a7 - daemon, lib: unify protolayer_grp and kr_proto enums
- dfe44a99 - daemon/session2: protocol layer refactors + docs
- b475d004 - daemon/proxyv2: move PROXY protocol into its own layer
- 9f6042c3 - daemon/session2: optimize allocations
- a805ad63 - Some more Clang-Tidy silencing
- 0a1f0024 - daemon/session2: fix asynchronous layer iterations
- 08b57521 - .gitlab-ci: use Arch for linting
- 313ddefd - daemon/session2.h: clarify `struct session2` docs
Toggle commit list-
5b0e3472...2c5d0df2 - 3 commits from branch
mentioned in commit bd5d4801