Make the modulesdir configurable at the runtime

This add support for configuring the moduledir either at the startup time (using kresd -m <new_moduledir>) or at the run time from lua (moduledir(<new_moduledir>)).

mentioned in merge request !286 (closed)

@ondrej: it's marked as WIP – do you plan more changes?

I am not happy with the fact the lua function always prepends the list instead of replacing the previous value. This could lead to unintended consequences of loading module from the former location if it is unavailable from the new location.

added 1 commit

• c370b31d - Make the modulesdir configurable at the runtime

Compare with previous version

added 2 commits

• a951e775 - Make the moduledir configurable at the runtime
• dd265891 - Update the moduledir documentation

Compare with previous version

unmarked as a Work In Progress

changed the description

assigned to @vcunat

changed the description

In the current MR state, if the module directory is changed, the install-time directory still works as a fallback for C modules but not for lua ones. We should unify that. I assume the intention is to keep this fallback for both and will implement it.

Although, it would feel slightly misleading that moduledir() returns just one directory if we actually searched two dirs.

OK, so we'll only load C modules from that single directory.

Issue for later: lua modules for kresd are still searched on quite a long list of directories (standard lua search path), which isn't ideal in combination with the short module names we use. One can successfully run e.g. modules = { 'ffi' }.

added 4 commits

• d4810e55 - engine: free hostname and moduledir (nitpick)
• e1bb66f6 - module.c: cleanup unused code
• 02827ce4 - module.c: don't fall back to MODULEDIR if overridden
• 167bc29c - NEWS: mention module changes

Compare with previous version

added 1 commit

• d400a6bc - man page: do maintenance

Compare with previous version

added 9 commits

• d400a6bc...15db5051 - 8 commits from branch master
• dfd12a41 - Merge master, to resolve a trivial conflict in NEWS

Compare with previous version

resolved all discussions

added 7 commits

• 2f81b111 - Make the moduledir configurable at the runtime
• a5c4724d - Update the moduledir documentation
• b3ae8bdf - engine: free hostname and moduledir (nitpick)
• 352da6ea - module.c: cleanup unused code
• 9ad4f88d - module.c: don't fall back to MODULEDIR if overridden
• e7baf329 - NEWS: mention module changes
• f37f1ed8 - man page: do maintenance

Compare with previous version

enabled an automatic merge when the pipeline for f37f1ed8 succeeds

merged

mentioned in commit 1f4ef090

mentioned in commit 6453a67e

mentioned in merge request !313 (merged)

@ondrej Do you remember what problem this intended to solve?

We decided to introduce a new namespace for modules (kres_modules) and it seems that override for moduledir is making things unnecessarily complex.

Simple require('kres_modules.etcd') should work and be sufficiently unambiguous to avoid conflicts with other libraries like require('etcd').

Are we missing some historical context here?

@vavrusam Hi! Do you remember something related to this? Are you using it? We plan to remove the option in next release because it seems to be unnecessary.

@pspacek I'm not using it