WIP: resolve: to_wire = false for failed kr_query (!660) · Merge requests · Knot projects / Knot Resolver

Closed Vladimír Čunát requested to merge bogus-clean into master 6 years ago

Sep 25, 2018
- resolve: use more sensitive detection of KR_STATE_FAIL · a881aa44
  Vladimír Čunát authored 6 years ago
  
  I don't know any particular case where the bit-test would succeed and equality wouldn't, but it seems better to take no chances.
  Verified
  
  a881aa44
- resolve: to_wire = false for failed kr_query · f4635493
  Vladimír Čunát authored 6 years ago
  
  Verified
  
  f4635493
- resolve answer_finalize(): simplify, fix minor problems · 43b640a8
  Vladimír Čunát authored 6 years ago
  
  Verified
  
  43b640a8
- kr_request_selected: change the approach · c7a44855
  Vladimír Čunát authored 6 years ago
  
  Verified
  
  c7a44855
- kr_request: remove ::additional · e824444b
  Vladimír Čunát authored 6 years ago
  
  Somehow I didn't notice this field when adding ::add_selected. We probably never put anything into answer's ADDITIONAL, so noone's noticed a problem.
  Verified
  
  e824444b
- lib/resolve: remove accessor functions · fd9376bd
  Vladimír Čunát authored 6 years ago
  
  I see no use to keep these when we access all the other members directly. Strictly taken, this breaks API+ABI, but I don't think anyone else would be using them, e.g. in their lua code.
  Verified
  
  fd9376bd
- resolve, worker: avoid duplicate state in some cases · 24647e8b
  Vladimír Čunát authored 6 years ago
  
  In these functions the extra passing of `state` in parameter and return value only served to add extra confusion with kr_request::state.
  Verified
  
  24647e8b

WIP: resolve: to_wire = false for failed kr_query

TODO:

Activity

Admin message

WIP: resolve: to_wire = false for failed kr_query

TODO:

Merge request reports

Activity