WIP: resolve: to_wire = false for failed kr_query

There are various cleanups and a loosely depending fix for https://gitlab.labs.nic.cz/knot/knot-resolver/issues/396.

TODO:

• deckard – something like the test in the issue, also extended with some CNAME chains.

added 14 commits

• 1d80c99d...00825119 - 6 commits from branch master
• c9594f63 - lib/resolve: remove accessor functions
• ed372c75 - worker: remove unused function prototype
• 230b8aec - worker: kill second names of functions
• 1ad37d3d - resolve, worker: avoid duplicate state in some cases
• f054460f - kr_request: remove ::additional
• 9b9ed9d7 - kr_request_selected: change the approach
• f8539599 - resolve answer_finalize(): simplify, fix minor problems
• 0a564740 - resolve: to_wire = false for failed kr_query

Compare with previous version

changed the description

marked as a Work In Progress

added 2 commits

• 613a9d0d - resolve answer_finalize(): simplify, fix minor problems
• 30e340aa - resolve: to_wire = false for failed kr_query

Compare with previous version

marked the checklist item deckard – something like the test in the issue, also extended with some CNAME chains. as completed

added 25 commits

• 30e340aa...16df54d9 - 17 commits from branch master
• 10f0b9aa - lib/resolve: remove accessor functions
• a4d03ec4 - worker: remove unused function prototype
• c02e6f1c - worker: kill second names of functions
• 2487a4ca - resolve, worker: avoid duplicate state in some cases
• 6520bb37 - kr_request: remove ::additional
• e3472563 - kr_request_selected: change the approach
• 9fac1957 - resolve answer_finalize(): simplify, fix minor problems
• 3b30e606 - resolve: to_wire = false for failed kr_query

Compare with previous version

added 7 commits

• d20e7019 - resolve, worker: avoid duplicate state in some cases
• 766c296f - lib/resolve: remove accessor functions
• ef476dd4 - kr_request: remove ::additional
• 7dbdef90 - kr_request_selected: change the approach
• e9f8f398 - resolve answer_finalize(): simplify, fix minor problems
• 6de70a41 - resolve: to_wire = false for failed kr_query
• 28f4faaf - resolve: use more sensitive detection of KR_STATE_FAIL

Compare with previous version

added 27 commits

• 28f4faaf...487f2109 - 20 commits from branch master
• 24647e8b - resolve, worker: avoid duplicate state in some cases
• fd9376bd - lib/resolve: remove accessor functions
• e824444b - kr_request: remove ::additional
• c7a44855 - kr_request_selected: change the approach
• 43b640a8 - resolve answer_finalize(): simplify, fix minor problems
• f4635493 - resolve: to_wire = false for failed kr_query
• a881aa44 - resolve: use more sensitive detection of KR_STATE_FAIL

Compare with previous version

Notes from meeting: Suspicious, after 3.2.

mentioned in merge request !827 (merged)

closed

reopened

I believe this will not convert NULL to nil.

An alternative approach: https://gitlab.labs.nic.cz/knot/knot-resolver/-/tree/bogus-clean-v3

Replaced by !975 (merged).

closed