Skip to content
Snippets Groups Projects

cache.clear('name') edge cases

Merged Vladimír Čunát requested to merge cache-clear-nitpicks into master
All threads resolved!

Fixes https://gitlab.labs.nic.cz/knot/knot-resolver/issues/401

I'm not really sure if rettable.subtree should contain the ffi.string() result or a tostring() from it, but I left it as it was (the former).

Edited by Vladimír Čunát

Merge request reports

Pipeline #41808 passed with warnings

Pipeline passed with warnings for 5e73af5d on cache-clear-nitpicks

Merged by Petr ŠpačekPetr Špaček 6 years ago (Oct 31, 2018 3:16pm UTC)

Loading

Pipeline #41860 passed

Pipeline passed for 81dffe33 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 39369ab7 - cache.clear('name'): fix a small GC race

    Compare with previous version

  • Vladimír Čunát resolved all discussions

    resolved all discussions

  • Vladimír Čunát added 10 commits

    added 10 commits

    • 39369ab7...88e78c66 - 7 commits from branch master
    • ad263d73 - kres.str2dname: perform lower-casing
    • 56cf1927 - cache.clear('name'): correct the 'not_apex" warning
    • eb868bc3 - cache.clear('name'): fix a small GC race

    Compare with previous version

  • Vladimír Čunát changed the description

    changed the description

  • Petr Špaček added 77 commits

    added 77 commits

    • eb868bc3...367a9070 - 74 commits from branch master
    • 23d5b99d - kres.str2dname: perform lower-casing
    • 4d91c80a - cache.clear('name'): correct the 'not_apex" warning
    • 5e73af5d - cache.clear('name'): fix a small GC race

    Compare with previous version

  • Petr Špaček enabled an automatic merge when the pipeline for 5e73af5d succeeds

    enabled an automatic merge when the pipeline for 5e73af5d succeeds

  • merged

  • Petr Špaček mentioned in commit 81dffe33

    mentioned in commit 81dffe33

  • Please register or sign in to reply
    Loading