Zone import/prefill
Merge request reports
Activity
Code seems okay but we need to sort out two things:
-
Tests need to be be trimmed because adding huge files will unnecessarily inflate Git repo and slow down everything. Please trim all test zones to couple lines, either valid or invalid.
-
Commit messages should explain reasons why the change was made instead of describing the change itself (that can be seen in the code anyway :-). Example: "zimport: checking return value of zi_state_parsing()" -> "zimport: avoid crash on zi_state_parsing() failure" etc.
Other than that it is good and I want to include it in release on Wednesday.
-
added 7 commits
-
638db08a...b11fe0be - 3 commits from branch
master
- 6057f675 - zimport: avoid crash on zi_state_parsing() failure
- d57c3935 - zimport: avoid crash on empty zone file
- 9b38be40 - prefill: check correct origin attribute
- 1cb01afc - prefill: tests for zone import
Toggle commit list-
638db08a...b11fe0be - 3 commits from branch
added 1 commit
- 270652f1 - NEWS: avoid crashing of preffil on empty file
mentioned in commit 591e384b
mentioned in issue #496 (closed)