Skip to content
Snippets Groups Projects

systemd: return kresd@ to system-kresd.slice

Merged Vladimír Čunát requested to merge systemd-slice into master

Regressed in 5.0.0 (!925 (merged)).

Edited by Vladimír Čunát

Merge request reports

Pipeline #58892 canceled

Pipeline canceled for 0b28f41c on systemd-slice

Approved by
Ready to merge by members who can write to the target branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Well, depends what "regressed" means. Apparently the slice specification was always missing in the unit without socket activation (e.g. for EPEL 7), even though it was there for kres-cache-gc.service.

  • It should be there now, according to docs and man page.

  • Tomas Krizek enabled an automatic merge when the pipeline for d7ffaa13 succeeds

    enabled an automatic merge when the pipeline for d7ffaa13 succeeds

  • Vladimír Čunát canceled the automatic merge

    canceled the automatic merge

  • Wait, this is weird. systemctl status system-kresd.slice shows it is in the slice already, but I can't see why.

  • I can only think of some magic due to dependencies with kres-cache-gc.service (which was explicitly put into the slice already), but I can't find any documentation about such properties.

    So it doesn't seem we have a bug here, but I still expect it's better to make it explicit (we need to remove or tweak the NEWS line, though EDIT: I forgot to commit that part, hehe, so perhaps just the commit message needs tweaking).

    In any case, it would be nice to understand why this happens, but that doesn't seem a big deal.

    Edited by Vladimír Čunát
  • My guess is systemd isn't updated or still uses the old configuration. I'd try stopping all the units, then systemctl daemon-reload and starting them again. Or even better, reboot. I'd be surprised if the services would still be part of the slice even after a clean reboot.

  • added 1 commit

    • 0b28f41c - systemd: explicitly add kresd@ to system-kresd.slice

    Compare with previous version

  • For some reason, kresd@*.service appear to be part of the slice anyway. My guess is it's probably created automatically by systemd, either because of the templating, or perhaps kresd.target. In any case, specifying the slice explicitly shouldn't be an issue.

  • mentioned in commit a5ef26d0

  • Vladimír Čunát changed the description

    changed the description

Please register or sign in to reply
Loading