per-request verbose logging and debug log improvements

marked as a Work In Progress

added 26 commits

• 053f3cd4...1eb85071 - 25 commits from branch master
• a83f20a9 - daemon/worker: add logging to qr_task_step query cancelation

Compare with previous version

added 2 commits

• b97da727 - iterate: log IP address sending mismatching answers
• 4c31e81f - debug: warn on qname letter case mismatch

Compare with previous version

added 5 commits

• 5a676cbc - fixup! debug: warn on qname letter case mismatch
• e5bc917f - WIP: helper functions for debug log
• 7f9d80e4 - fixup! WIP: helper functions for debug log
• db3deb26 - unify verbose logging and request tracing
• 1b6b1305 - WIP: policy.DEBUG

Compare with previous version

added 6 commits

• 19a53a4e - debug: warn on qname letter case mismatch
• cc036846 - WIP: helper functions for debug log
• 0c61d36e - unify verbose logging and request tracing
• 5b7fe854 - WIP: policy.DEBUG
• e8dfc040 - policy.DEBUG: log also final answer seen by policy module
• a7614650 - policy: doc reorganization and clarification

Compare with previous version

added 16 commits

• a7614650...c1a34426 - 5 commits from branch master
• e728c987 - daemon/worker: add logging to qr_task_step query cancelation
• 6f19b7e4 - iterate: log IP address sending mismatching answers
• 2322b1a6 - debug: warn on qname letter case mismatch
• 5d27692c - lua: helper functions for debug log
• a914b386 - unify verbose logging and request tracing
• 4c4a3d39 - policy.DEBUG: log also final answer seen by policy module
• c6dee0af - policy: doc reorganization and clarification
• a754191d - policy.DEBUG: generalize DEBUG_CACHE_MISS into DEBUG_IF
• b49e576c - policy.DEBUG: add also policy.REQTRACE for printing incomming packets
• 79c4c3fb - validator: clarify message about signed non-authoritative data
• f93217a5 - cache: remove forgotten log message "writing RRsets"

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: daemon/worker: add logging to qr_task_step query cancelation to per-request verbose logging and debug log improvements

added usability label

• verify upgrading guide
• check all linters
• proofread docs!

added 14 commits

• f93217a5...7e021d4a - 2 commits from branch master
• 0e1201cc - daemon/worker: add logging to qr_task_step query cancelation
• 59e81f09 - iterate: log IP address sending mismatching answers
• 79f6b64e - debug: warn on qname letter case mismatch
• c9cffe23 - lua: helper functions for debug log
• 4626b462 - unify verbose logging and request tracing
• 12186825 - policy.DEBUG: log also final answer seen by policy module
• c637eb32 - policy: doc reorganization and clarification
• d22a9a5c - policy.DEBUG: generalize DEBUG_CACHE_MISS into DEBUG_IF
• fc6bd3f2 - policy.DEBUG: add also policy.REQTRACE for printing incomming packets
• e8fafe22 - validator: clarify message about signed non-authoritative data
• 416f0be5 - cache: remove forgotten log message "writing RRsets"
• db3c0a06 - lua: expose cache miss detection in request objects

Compare with previous version

added 10 commits

• f8077d31 - debug: warn on qname letter case mismatch
• 5576f78d - lua: helper functions for debug log
• acd1801b - unify verbose logging and request tracing
• 04b0095c - policy.DEBUG: log also final answer seen by policy module
• 009f2927 - policy: doc reorganization and clarification
• 8b8f4898 - policy.DEBUG: generalize DEBUG_CACHE_MISS into DEBUG_IF
• f788d0e2 - policy.DEBUG: add also policy.REQTRACE for printing incomming packets
• 45b6ac2d - validator: clarify message about signed non-authoritative data
• 3af5db91 - cache: remove forgotten log message "writing RRsets"
• 7ae864e8 - lua: expose cache miss detection in request objects

Compare with previous version

I really like these changes, query logging seems really useful!

I read through the code and it looks good. I didn't check all the newly produced logs, but it seems fine with a quick glance.

However, the upgrading guide felt a bit lackluster, I wouldn't really be sure what has changed without reading through the code changes in this MR.

added 5 commits

• d69d994b - fixup! unify verbose logging and request tracing
• 7524ce36 - fixup! policy.DEBUG: log also final answer seen by policy module
• edd3059c - fixup! policy.DEBUG: generalize DEBUG_CACHE_MISS into DEBUG_IF
• 2f9eb8a1 - fixup! policy: doc reorganization and clarification
• 52910f8d - fixup! policy.DEBUG: generalize DEBUG_CACHE_MISS into DEBUG_IF

Compare with previous version

marked as a Work In Progress from d69d994b

I've pushed fixups, please amend the wording as you feel it and merge the whole thing (if that's the only thing left).