Skip to content
Snippets Groups Projects
  1. Feb 22, 2019
  2. Feb 19, 2019
  3. Feb 17, 2019
    • Ondřej Zajíček's avatar
      OSPF: Reset LSAs during area type change · bf8d7bba
      Ondřej Zajíček authored
      When area is reconfigured to a different type, we need to flush LSAs as
      they may not be valid (e.g. NSSA-LSA for non-NSSA area). Also, when we
      have have just one OSPF area and that changes type, we could restart OSPF
      as there is no state to keep anyway. That solves issue with different
      handling of external routes exported to OSPF based of main area type.
      bf8d7bba
  4. Feb 13, 2019
  5. Feb 09, 2019
  6. Feb 05, 2019
    • Ondřej Zajíček's avatar
      Nest: Improve export counter handling · 6e8fb668
      Ondřej Zajíček authored
      One of previous workarounds for phantom route avoidance breaks export
      counters by expanding sending of spurious withdraws, which are send when
      we are not sure whether we have advertised that routes in the past.
      If not, then export counter is decreased, but it was not increased
      before, so it overflows under zero.
      
      The patch fixes that by sendung spurious withdraws, but not counting them
      on export counter. That may lead to error in the other direction, but that
      happens only as a race condition (i.e., in normal operation filters
      return proper values about old route export state).
      6e8fb668
    • Ondřej Zajíček's avatar
      Nest: Report preferred counters also when 'import keep filtered' is enabled · 52fdd1cb
      Ondřej Zajíček authored
      Thanks to Michal Nowak for reporting the issue.
      52fdd1cb
  7. Feb 03, 2019
  8. Feb 02, 2019
  9. Feb 01, 2019
  10. Jan 31, 2019
  11. Jan 30, 2019
    • Ondřej Zajíček's avatar
      Nest: Prevent withdraws from propagation back to source protocol · e84c81b7
      Ondřej Zajíček authored
      The earlier fix loosen conditions for not running filters on old
      route when deciding about route propagation to a protocol to avoid
      issues with ghost routes in some race conditions.
      
      Unfortunately, the fix also caused back-propagation of withdraws. For
      regular updates, back-propagation is prevented in import_control hooks,
      but these are not called on withdraws. For them, import_control hooks
      are called on old routes instead, changing (old, NULL) notification
      to (NULL, NULL), which is ignored. By not calling export processing
      in some cases, the withdraw is not ignored and is back-propagated.
      
      This patch fixes that by contract conditions so the earlier fix is not
      applied to back-propagated updates.
      e84c81b7
  12. Jan 26, 2019
  13. Jan 24, 2019
  14. Jan 17, 2019
  15. Jan 05, 2019
  16. Jan 04, 2019
  17. Jan 03, 2019
    • Ondřej Zajíček's avatar
      Doc: README and INSTALL update · 4d9049dc
      Ondřej Zajíček authored
      Minor cleanups, updates and clarifications. Also removes (incomplete
      and well-known) build steps from README, as they are better described
      in INSTALL.
      4d9049dc
  18. Jan 02, 2019
    • Ondřej Zajíček's avatar
      BGP: Better dispatch of incoming connections · 470740f9
      Ondřej Zajíček authored
      Since v2 we have multiple listening BGP sockets, and each BGP protocol
      has associated one of them. Use listening socket that accepted the
      incoming connection as a key in the dispatch process so only BGP
      protocols assocaited with that listening socket can be selected.
      This is necesary for proper dispatch when VRFs are used.
      470740f9
    • Ondřej Zajíček's avatar
      BGP: Postpone setting link_addr · e16b0aef
      Ondřej Zajíček authored
      It may happen that the LLv6 address for given iface is not defined during
      BGP start, so we postpone the check to the the session establishment.
      e16b0aef
  19. Dec 28, 2018
  20. Dec 18, 2018
  21. Dec 17, 2018
    • Ondřej Zajíček's avatar
      OSPF: Fix wrong LSA collisions detection · cea2e25f
      Ondřej Zajíček authored
      In some circumstances (old LSA flushed but not acknowledged and not
      removed) origination of a new LSA may wrongly triggers LSA collision
      code. The patch fixes that.
      
      Thanks to Asbjorn Mikkelsen for the bugreport and @mdelagueronniere
      for the original patch.
      cea2e25f
  22. Dec 16, 2018
    • Ondřej Zajíček's avatar
      BGP: Extend 'next hop keep' and 'next hop self' options · 1cab2b4a
      Ondřej Zajíček authored
      Extend 'next hop keep' and 'next hop self' options to have boolean values
      (enabled / disabled) and also values 'ibgp'/ 'ebgp' to restrict it to
      routes received from IBGP / EBGP. This allows to have it enabled by
      default in some cases, matches features of other implementations, and
      allows to handle some strange cases like EBGP border router with 'next
      hop self' also doing IBGP route reflecting.
      
      Change default of 'next hop keep' to enabled for route servers, and
      'ibgp' for route reflectors.
      
      Update documentation for these options.
      1cab2b4a