Eugene Bogomazov authored 5 years ago and Ondřej Zajíček committed 5 years ago

ASPA [1] is a new IETF draft for BGP that adds new RPKI objects and
create an AS_PATH validation mechanism [2] based on this objects.

[1] https://datatracker.ietf.org/doc/draft-ietf-sidrops-aspa-profile/
[2] https://datatracker.ietf.org/doc/draft-ietf-sidrops-aspa-verification/

(Minor changes done by commiter)

We already had them defined on BGP level, but they are more general.

For regular channels do not compare src in export table, as we want to
keep here only the best (exported) route per network.

The route is changed by rte_make_tmp_attrs(), so we need to compare
net->routes to the original one.

Thanks to Kenth Eriksson for the bugreport.

Transitive extended communities should be removed on external sessions,
the old code them in all cases.

Thanks to Jean-Daniel Pauget for the original patch.

Names read from texfiles in /etc/iproute2/* are normalized by replacing
non-alphanumeric chars with underscore. The patch fixes handling of
uppercase letters, which were handled as non-alphanumberic.

Thanks to Igor Gavrilov for the bugreport.

Fabrice Fontaine authored 5 years ago and Ondřej Zajíček committed 5 years ago

(CHECK keyword added by commiter)

The old code used just sizeof(struct sockaddr) bytes of IP address.

Change of some options requires route refresh, but when import table is
active, channel reload is done from it instead of doing full route
refresh. So in this case we request it internally.

Thanks to Christoph for the bugreport.

When non-MPLS recursive route resolves to MPLS underlying route,
then it should get MPLS labels from the the underlying route.

Underlying (IGP) route may lead to PtP link, in this case it does not
need gateway. Which is different than direct route without gateway.

When recursive (BGP) route uses PtP route, it should not use recursive
next hop as immediate next hop, while for direct routes it should.

Missing cleanup can lead to dangling pointer to old next hops.

Use 'l' for s64/u64 instead of for long/ulong, as that is much more
useful. Also make number() correct with regard to signed/unsigned
typecasts.

Thanks to elados93 for the patch.

The C11 specification allows only sig_atomic_t and _Atomic variable
access. All other accesses to global variables are undefined behavior.

Using int was probably OK on x86 and x86_64; yet there were some reports
from other architectures (especially some MIPS) that in rare cases,
after issuing SIGHUP, BIRD did strange things.

The bfd_reconfigure_neighbors() returned after first reconfigured
neighbor instead of continuing with the next one.

Thanks to Winston Chen for the bugreport and a patch.

Exported route may be in modified state, we need to get cached one for
rte_same() and rta_clone() to work properly.

Multi-worded commands are not automatically added to top-level
help output.

Thanks to Christoph for the bugreport.

Function bodies were compared in post-parse time, yet the result was not
used and the functions were incorrectly considered the same as before.

Now the result is used to reload affected protocols.

Based on a patch from Liam Nattrass, thanks.

The old 'where' code computed size value incorrectly, which leads
to invalid instruction lines and filter errors or crashes.

The attribute should not be modifiable by filters as we do not
support its type.

There is an improper check for valid message size, which may lead to
stack overflow and buffer leaks to log when a large message is received.

Thanks to Daniel McCarney for bugreport and analysis.

It crashed when used without protocol argument.

Thanks to Alexander for the bugreport.

We forgot to do that. Oops.

Instead of having large stack buffer for max amount of AFI/SAFI pairs.
The old code is not correct w.r.t. extendeded option length, as more
AFI/SAFI pairs may fit into the capability option.

Extends BGP options/capabilities data length to 16bit, to avoid issues
with too many capabilities. See draft-ietf-idr-ext-opt-param-07